From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1314) id 1985D385B805; Tue, 9 Nov 2021 19:03:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1985D385B805 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Pinski To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5071] [Committed] Fix tree-optimization/103152: Still one more -signed1bit issue X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 56af35de3d11960100996b96034dc9ccd7c75ca3 X-Git-Newrev: f7844b6a777cb47fec7208d7bd594f6ce66f1daa Message-Id: <20211109190356.1985D385B805@sourceware.org> Date: Tue, 9 Nov 2021 19:03:56 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 19:03:56 -0000 https://gcc.gnu.org/g:f7844b6a777cb47fec7208d7bd594f6ce66f1daa commit r12-5071-gf7844b6a777cb47fec7208d7bd594f6ce66f1daa Author: Andrew Pinski Date: Tue Nov 9 09:56:10 2021 +0000 [Committed] Fix tree-optimization/103152: Still one more -signed1bit issue When I fixed PR 102622, I accidently left behind a TYPE_PRECISION check which I had there for checking before hand. This check is not needed as the code will handle it correctly anyways. Committed as obvious after a bootstrap/test on x86_64-linux-gnu. PR tree-optimization/10352 gcc/ChangeLog: * match.pd: Remove check of TYPE_PRECISION for the a?0:pow2 case. gcc/testsuite/ChangeLog: * gcc.c-torture/execute/pr10352-1.c: New test. Diff: --- gcc/match.pd | 3 +-- gcc/testsuite/gcc.c-torture/execute/pr10352-1.c | 12 ++++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/gcc/match.pd b/gcc/match.pd index cdab5e59f4e..986b052bc93 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -4056,8 +4056,7 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (if (integer_onep (@2)) (convert (bit_xor (convert:boolean_type_node @0) { booltrue; } ))) /* a ? powerof2cst : 0 -> (!a) << (log2(powerof2cst)) */ - (if (INTEGRAL_TYPE_P (type) && integer_pow2p (@2) - && TYPE_PRECISION (type) != 1) + (if (INTEGRAL_TYPE_P (type) && integer_pow2p (@2)) (with { tree shift = build_int_cst (integer_type_node, tree_log2 (@2)); } diff --git a/gcc/testsuite/gcc.c-torture/execute/pr10352-1.c b/gcc/testsuite/gcc.c-torture/execute/pr10352-1.c new file mode 100644 index 00000000000..babb9d45a28 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/pr10352-1.c @@ -0,0 +1,12 @@ +/* this is another case where phiopt + would create -signed1bit which is undefined. */ +struct { + int a:1; +} b; +int *c = (int *)&b, d; +int main() { + d = c && (b.a = (d < 0) ^ 3); + if (d != 1) + __builtin_abort(); + return 0; +}