public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5078] aarch64: [PR101529] Fix vector shuffle insertion expansion Date: Wed, 10 Nov 2021 04:07:38 +0000 (GMT) [thread overview] Message-ID: <20211110040738.95D6D3858405@sourceware.org> (raw) https://gcc.gnu.org/g:52fa771758635d9c53cddb9116e5a66fae592230 commit r12-5078-g52fa771758635d9c53cddb9116e5a66fae592230 Author: Andrew Pinski <apinski@marvell.com> Date: Sat Nov 6 06:29:13 2021 +0000 aarch64: [PR101529] Fix vector shuffle insertion expansion The function aarch64_evpc_ins would reuse the target even though it might be the same register as the two inputs. Instead of checking to see if we can reuse the target, just use the original input directly. Committed as approved after bootstrapped and tested on aarch64-linux-gnu with no regressions. PR target/101529 gcc/ChangeLog: * config/aarch64/aarch64.c (aarch64_evpc_ins): Don't use target as an input, use original one. gcc/testsuite/ChangeLog: * c-c++-common/torture/builtin-convertvector-2.c: New test. * c-c++-common/torture/builtin-shufflevector-2.c: New test. Diff: --- gcc/config/aarch64/aarch64.c | 3 +-- .../c-c++-common/torture/builtin-convertvector-2.c | 26 ++++++++++++++++++++++ .../c-c++-common/torture/builtin-shufflevector-2.c | 26 ++++++++++++++++++++++ 3 files changed, 53 insertions(+), 2 deletions(-) diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 19f67415234..e23d7cf3d8f 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -23102,11 +23102,10 @@ aarch64_evpc_ins (struct expand_vec_perm_d *d) } gcc_assert (extractindex < nelt); - emit_move_insn (d->target, insv); insn_code icode = code_for_aarch64_simd_vec_copy_lane (mode); expand_operand ops[5]; create_output_operand (&ops[0], d->target, mode); - create_input_operand (&ops[1], d->target, mode); + create_input_operand (&ops[1], insv, mode); create_integer_operand (&ops[2], 1 << idx); create_input_operand (&ops[3], extractv, mode); create_integer_operand (&ops[4], extractindex); diff --git a/gcc/testsuite/c-c++-common/torture/builtin-convertvector-2.c b/gcc/testsuite/c-c++-common/torture/builtin-convertvector-2.c new file mode 100644 index 00000000000..d88f6a72b5c --- /dev/null +++ b/gcc/testsuite/c-c++-common/torture/builtin-convertvector-2.c @@ -0,0 +1,26 @@ +/* { dg-do run } */ +/* PR target/101529 */ + +typedef unsigned char __attribute__((__vector_size__ (1))) W; +typedef unsigned char __attribute__((__vector_size__ (8))) V; +typedef unsigned short __attribute__((__vector_size__ (16))) U; + +unsigned short us; + +/* aarch64 used to miscompile foo to just return 0. */ +W +foo (unsigned char uc) +{ + V v = __builtin_convertvector ((U){ } >= us, V); + return __builtin_shufflevector ((W){ }, v, 4) & uc; +} + +int +main (void) +{ + W x = foo (5); + if (x[0] != 5) + __builtin_abort(); + return 0; +} + diff --git a/gcc/testsuite/c-c++-common/torture/builtin-shufflevector-2.c b/gcc/testsuite/c-c++-common/torture/builtin-shufflevector-2.c new file mode 100644 index 00000000000..7c4999ed4e9 --- /dev/null +++ b/gcc/testsuite/c-c++-common/torture/builtin-shufflevector-2.c @@ -0,0 +1,26 @@ +/* { dg-do run} */ +/* PR target/101529 */ +typedef unsigned char C; +typedef unsigned char __attribute__((__vector_size__ (8))) V; +typedef unsigned char __attribute__((__vector_size__ (32))) U; + +C c; + +/* aarch64 used to miscompile foo to just return a vector of 0s */ +V +foo (V v) +{ + v |= __builtin_shufflevector (c * v, (U) (0 == (U){ }), + 0, 1, 8, 32, 8, 20, 36, 36); + return v; +} + +int +main (void) +{ + V v = foo ((V) { }); + for (unsigned i = 0; i < sizeof (v); i++) + if (v[i] != (i >= 2 ? 0xff : 0)) + __builtin_abort (); + return 0; +}
reply other threads:[~2021-11-10 4:07 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211110040738.95D6D3858405@sourceware.org \ --to=pinskia@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).