public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Martin Liska <marxin@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/marxin/heads/loop-unswitch-improvement)] Fix floating point types.
Date: Mon, 22 Nov 2021 12:44:43 +0000 (GMT)	[thread overview]
Message-ID: <20211122124443.28C713858422@sourceware.org> (raw)

https://gcc.gnu.org/g:cc9dcdf4997c7e5db3f58832a1130081c661b7c2

commit cc9dcdf4997c7e5db3f58832a1130081c661b7c2
Author: Martin Liska <mliska@suse.cz>
Date:   Tue Nov 16 10:32:10 2021 +0100

    Fix floating point types.

Diff:
---
 gcc/tree-ssa-loop-unswitch.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/gcc/tree-ssa-loop-unswitch.c b/gcc/tree-ssa-loop-unswitch.c
index 895b47b968e..e465e14a6ab 100644
--- a/gcc/tree-ssa-loop-unswitch.c
+++ b/gcc/tree-ssa-loop-unswitch.c
@@ -244,15 +244,20 @@ tree_may_unswitch_on (basic_block bb, class loop *loop, gimple_ranger *ranger)
 	return NULL;
     }
 
-  cond = build2 (gimple_cond_code (stmt), boolean_type_node,
-		 gimple_cond_lhs (stmt), gimple_cond_rhs (stmt));
+  tree lhs = gimple_cond_lhs (stmt);
+  tree rhs = gimple_cond_rhs (stmt);
 
+  cond = build2 (gimple_cond_code (stmt), boolean_type_node, lhs, rhs);
   edge edge_true, edge_false;
   extract_true_false_edges_from_block (bb, &edge_true, &edge_false);
 
   unswitch_predicate *predicate = new unswitch_predicate (stmt, cond);
-  ranger->range_on_edge (predicate->true_range, edge_true, gimple_cond_lhs (stmt));
-  ranger->range_on_edge (predicate->false_range, edge_false, gimple_cond_lhs (stmt));
+  if (irange::supports_type_p (TREE_TYPE (lhs)))
+    {
+      ranger->range_on_edge (predicate->true_range, edge_true, lhs);
+      ranger->range_on_edge (predicate->false_range, edge_false, rhs);
+    }
+
   return predicate;
 }
 
@@ -278,7 +283,7 @@ simplify_using_entry_checks (unswitch_predicate *predicate,
 	      && operand_equal_p (gimple_cond_rhs (stmt),
 				  TREE_OPERAND (cond, 1), 0))
 	    return true_edge ? boolean_true_node : boolean_false_node;
-	  else
+	  else if (irange::supports_type_p (TREE_TYPE (gimple_cond_lhs (stmt))))
 	    {
 	      int_range_max r;
 	      irange &parent_range = (true_edge ? parent_predicate->true_range :


             reply	other threads:[~2021-11-22 12:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 12:44 Martin Liska [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-11-19 14:34 Martin Liska
2021-11-19 13:53 Martin Liska
2021-11-16  9:46 Martin Liska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211122124443.28C713858422@sourceware.org \
    --to=marxin@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).