public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Jeff Law <law@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5460] Re: [PATCH] PR tree-optimization/102232 Adding a missing pattern to match.pd Date: Tue, 23 Nov 2021 03:08:43 +0000 (GMT) [thread overview] Message-ID: <20211123030843.9C2663858409@sourceware.org> (raw) https://gcc.gnu.org/g:df1a0d526e2e4c75311345c0b73ce8483e243899 commit r12-5460-gdf1a0d526e2e4c75311345c0b73ce8483e243899 Author: Navid Rahimi <navidrahimi@microsoft.com> Date: Mon Nov 22 22:07:35 2021 -0500 Re: [PATCH] PR tree-optimization/102232 Adding a missing pattern to match.pd PR tree-optimization/102232 gcc/ * match.pd (x * (1 + y / x) - y) -> (x - y % x): New optimization. gcc/testsuite/ * gcc.dg/tree-ssa/pr102232.c: Testcase for this optimization. Diff: --- gcc/match.pd | 6 ++++ gcc/testsuite/gcc.dg/tree-ssa/pr102232.c | 52 ++++++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+) diff --git a/gcc/match.pd b/gcc/match.pd index 5d71a4f907c..886f807ac04 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -651,6 +651,12 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (if (INTEGRAL_TYPE_P (type) || VECTOR_INTEGER_TYPE_P (type)) (convert (trunc_mod @0 @1)))) +/* x * (1 + y / x) - y -> x - y % x */ +(simplify + (minus (mult:cs @0 (plus:s (trunc_div:s @1 @0) integer_onep)) @1) + (if (INTEGRAL_TYPE_P (type)) + (minus @0 (trunc_mod @1 @0)))) + /* Optimize TRUNC_MOD_EXPR by a power of two into a BIT_AND_EXPR, i.e. "X % C" into "X & (C - 1)", if X and C are positive. Also optimize A % (C << N) where C is a power of 2, diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr102232.c b/gcc/testsuite/gcc.dg/tree-ssa/pr102232.c new file mode 100644 index 00000000000..62bca6922ab --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr102232.c @@ -0,0 +1,52 @@ +/* PR tree-optimization/102232 */ +/* { dg-do run } */ +/* { dg-options "-O -fdump-tree-optimized" } */ + +int __attribute__ ((noipa)) foo (int a, int b) +{ + return b * (1 + a / b) - a; +} + +int +main (void) +{ + // few randomly generated test cases + if (foo (71856034, 238) != 212) + { + __builtin_abort (); + } + if (foo (71856034, 10909) != 1549) + { + __builtin_abort (); + } + if (foo (20350, 1744) != 578) + { + __builtin_abort (); + } + if (foo (444813, 88563) != 86565) + { + __builtin_abort (); + } + if (foo (112237, 63004) != 13771) + { + __builtin_abort (); + } + if (foo (68268386, 787116) != 210706) + { + __builtin_abort (); + } + if (foo (-444813, 88563) != 90561) + { + __builtin_abort (); + } + if (foo (-68268386, 787116) != 1363526) + { + __builtin_abort (); + } + + return 0; +} + +/* Verify that multiplication and division has been removed. */ +/* { dg-final { scan-tree-dump-not " \\* " "optimized" } } */ +/* { dg-final { scan-tree-dump-not " / " "optimized" } } */ \ No newline at end of file
reply other threads:[~2021-11-23 3:08 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211123030843.9C2663858409@sourceware.org \ --to=law@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).