public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-5519] Continue RTL verifying in rtl_verify_fallthru
Date: Thu, 25 Nov 2021 13:24:31 +0000 (GMT)	[thread overview]
Message-ID: <20211125132431.1FA003858434@sourceware.org> (raw)

https://gcc.gnu.org/g:8addb0b1279433de1e51a5ed4eb20a71bbd76f9f

commit r12-5519-g8addb0b1279433de1e51a5ed4eb20a71bbd76f9f
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Nov 24 15:57:03 2021 +0100

    Continue RTL verifying in rtl_verify_fallthru
    
    One case used fatal_insn which does not return which isn't
    intended as can be seen by the following erro = 1.  The following
    change refactors this to inline the relevant parts of fatal_insn
    instead and continue validating the RTL IL.
    
    2021-11-25  Richard Biener  <rguenther@suse.de>
    
            * cfgrtl.c (rtl_verify_fallthru): Do not stop verifying
            with fatal_insn.
            (skip_insns_after_block): Remove unreachable break and continue.

Diff:
---
 gcc/cfgrtl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c
index e3a724bddb4..c7ba9006b4e 100644
--- a/gcc/cfgrtl.c
+++ b/gcc/cfgrtl.c
@@ -3001,7 +3001,8 @@ rtl_verify_fallthru (void)
 		{
 		  error ("verify_flow_info: Incorrect fallthru %i->%i",
 			 e->src->index, e->dest->index);
-		  fatal_insn ("wrong insn in the fallthru edge", insn);
+		  error ("wrong insn in the fallthru edge");
+		  debug_rtx (insn);
 		  err = 1;
 		}
 	}
@@ -3540,10 +3541,8 @@ skip_insns_after_block (basic_block bb)
 	    {
 	    case NOTE_INSN_BLOCK_END:
 	      gcc_unreachable ();
-	      continue;
 	    default:
 	      continue;
-	      break;
 	    }
 	  break;


                 reply	other threads:[~2021-11-25 13:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211125132431.1FA003858434@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).