From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1130) id 8F5553857818; Tue, 30 Nov 2021 09:53:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8F5553857818 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Sandiford To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5605] Mark IFN_UBSAN_CHECK_ADD/MUL as commutative X-Act-Checkin: gcc X-Git-Author: Richard Sandiford X-Git-Refname: refs/heads/master X-Git-Oldrev: 71207246b02b33c1ceb169db54fddaa5c5c31824 X-Git-Newrev: 12e38012786d18b21ecb85c5d13b532281206270 Message-Id: <20211130095326.8F5553857818@sourceware.org> Date: Tue, 30 Nov 2021 09:53:26 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2021 09:53:26 -0000 https://gcc.gnu.org/g:12e38012786d18b21ecb85c5d13b532281206270 commit r12-5605-g12e38012786d18b21ecb85c5d13b532281206270 Author: Richard Sandiford Date: Tue Nov 30 09:52:26 2021 +0000 Mark IFN_UBSAN_CHECK_ADD/MUL as commutative gcc/ * internal-fn.c (commutative_binary_fn_p): Handle IFN_UBSAN_CHECK_ADD and IFN_UBSAN_CHECK_MUL. gcc/testsuite/ * gcc.dg/ubsan/commutative-1.c: New test. Diff: --- gcc/internal-fn.c | 2 ++ gcc/testsuite/gcc.dg/ubsan/commutative-1.c | 30 ++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/gcc/internal-fn.c b/gcc/internal-fn.c index 3d4055d29ee..0e377b1b1f8 100644 --- a/gcc/internal-fn.c +++ b/gcc/internal-fn.c @@ -3832,6 +3832,8 @@ commutative_binary_fn_p (internal_fn fn) case IFN_FMIN: case IFN_FMAX: case IFN_COMPLEX_MUL: + case IFN_UBSAN_CHECK_ADD: + case IFN_UBSAN_CHECK_MUL: return true; default: diff --git a/gcc/testsuite/gcc.dg/ubsan/commutative-1.c b/gcc/testsuite/gcc.dg/ubsan/commutative-1.c new file mode 100644 index 00000000000..128f5b14697 --- /dev/null +++ b/gcc/testsuite/gcc.dg/ubsan/commutative-1.c @@ -0,0 +1,30 @@ +/* { dg-do compile } */ +/* { dg-options "-fsanitize=undefined -fdump-tree-optimized" } */ +/* { dg-skip-if "" { *-*-* } { "-O0" "-flto" } { "" } } */ + +int res[2]; + +void +f1 (int x, int y) +{ + res[0] = x + y; + res[1] = y + x; +} + +void +f2 (int x, int y) +{ + res[0] = x - y; + res[1] = y - x; +} + +void +f3 (int x, int y) +{ + res[0] = x * y; + res[1] = y * x; +} + +/* { dg-final { scan-tree-dump-times {\.UBSAN_CHECK_ADD} 1 "optimized" } } */ +/* { dg-final { scan-tree-dump-times {\.UBSAN_CHECK_SUB} 2 "optimized" } } */ +/* { dg-final { scan-tree-dump-times {\.UBSAN_CHECK_MUL} 1 "optimized" } } */