From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1130) id 0B19B385B83E; Tue, 30 Nov 2021 09:53:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B19B385B83E MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Sandiford To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5609] vect: Fix SVE mask_gather_load/store_store tests X-Act-Checkin: gcc X-Git-Author: Richard Sandiford X-Git-Refname: refs/heads/master X-Git-Oldrev: 9b577047eec65936a5299cac13dd7b73cdfc4ae4 X-Git-Newrev: 8bb81b3c4945dbae8d490e7a4054ddeb5a3b506c Message-Id: <20211130095347.0B19B385B83E@sourceware.org> Date: Tue, 30 Nov 2021 09:53:47 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2021 09:53:47 -0000 https://gcc.gnu.org/g:8bb81b3c4945dbae8d490e7a4054ddeb5a3b506c commit r12-5609-g8bb81b3c4945dbae8d490e7a4054ddeb5a3b506c Author: Richard Sandiford Date: Tue Nov 30 09:52:28 2021 +0000 vect: Fix SVE mask_gather_load/store_store tests If-conversion now applies rewrite_to_defined_overflow to the address calculation in an IFN_MASK_LOAD. This means that we end up with: cast_base = (uintptr_t) base; uncast_sum = cast_base + offset; sum = (orig_type *) uncast_sum; If the target supports IFN_MASK_GATHER_LOAD with pointer-sized offsets for the given vectype, we wouldn't look through the sum cast and so would needlessly vectorise the uncast_sum addition. This showed up as several failures in gcc.target/aarch64/sve. gcc/ * tree-vect-data-refs.c (vect_check_gather_scatter): Continue processing conversions if the current offset is a pointer. Diff: --- gcc/tree-vect-data-refs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/tree-vect-data-refs.c b/gcc/tree-vect-data-refs.c index f1d7f01a9ce..888ad72f3a9 100644 --- a/gcc/tree-vect-data-refs.c +++ b/gcc/tree-vect-data-refs.c @@ -4139,6 +4139,7 @@ vect_check_gather_scatter (stmt_vec_info stmt_info, loop_vec_info loop_vinfo, /* Don't include the conversion if the target is happy with the current offset type. */ if (use_ifn_p + && !POINTER_TYPE_P (TREE_TYPE (off)) && vect_gather_scatter_fn_p (loop_vinfo, DR_IS_READ (dr), masked_p, vectype, memory_type, TREE_TYPE (off), scale, &ifn,