public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5615] Remove can_throw_non_call_exceptions special case from operator_div::wi_fold. Date: Tue, 30 Nov 2021 10:23:39 +0000 (GMT) [thread overview] Message-ID: <20211130102339.7C460385B83A@sourceware.org> (raw) https://gcc.gnu.org/g:f33fdda0b805ff6097f9f325d73a4b07e72170b0 commit r12-5615-gf33fdda0b805ff6097f9f325d73a4b07e72170b0 Author: Aldy Hernandez <aldyh@redhat.com> Date: Mon Nov 29 12:52:45 2021 +0100 Remove can_throw_non_call_exceptions special case from operator_div::wi_fold. PR tree-optimization/103451 gcc/ChangeLog: * range-op.cc (operator_div::wi_fold): Remove can_throw_non_call_exceptions special case. * tree-ssa-sink.c (sink_code_in_bb): Same. gcc/testsuite/ChangeLog: * gcc.dg/pr103451.c: New test. Diff: --- gcc/range-op.cc | 7 ------- gcc/testsuite/gcc.dg/pr103451.c | 19 +++++++++++++++++++ gcc/tree-ssa-sink.c | 4 +++- 3 files changed, 22 insertions(+), 8 deletions(-) diff --git a/gcc/range-op.cc b/gcc/range-op.cc index bbf2924f815..6fe5f1cb4e0 100644 --- a/gcc/range-op.cc +++ b/gcc/range-op.cc @@ -1832,13 +1832,6 @@ operator_div::wi_fold (irange &r, tree type, return; } - // If flag_non_call_exceptions, we must not eliminate a division by zero. - if (cfun->can_throw_non_call_exceptions) - { - r.set_varying (type); - return; - } - // If we're definitely dividing by zero, there's nothing to do. if (wi_zero_p (type, divisor_min, divisor_max)) { diff --git a/gcc/testsuite/gcc.dg/pr103451.c b/gcc/testsuite/gcc.dg/pr103451.c new file mode 100644 index 00000000000..c701934603e --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr103451.c @@ -0,0 +1,19 @@ +// { dg-do compile } +// { dg-options "-O2 -w -fnon-call-exceptions -fno-delete-dead-exceptions -fdump-tree-optimized" } + +int func_10_ptr_12; + +void func_10(long li_8) +{ + long *ptr_9 = &li_8; + li_8 &= *ptr_9 / 0 ?: li_8; + for (;;) + func_10_ptr_12 &= 4 ? *ptr_9 : 4; +} + +void func_9_s_8() +{ + func_10(func_9_s_8); +} + +// { dg-final { scan-tree-dump " / 0" "optimized" } } diff --git a/gcc/tree-ssa-sink.c b/gcc/tree-ssa-sink.c index 92f444ec1c8..c5d67840be3 100644 --- a/gcc/tree-ssa-sink.c +++ b/gcc/tree-ssa-sink.c @@ -696,7 +696,9 @@ sink_code_in_bb (basic_block bb) /* If we face a dead stmt remove it as it possibly blocks sinking of uses. */ if (zero_uses_p - && ! gimple_vdef (stmt)) + && !gimple_vdef (stmt) + && (cfun->can_delete_dead_exceptions + || !stmt_could_throw_p (cfun, stmt))) { gsi_remove (&saved, true); release_defs (stmt);
reply other threads:[~2021-11-30 10:23 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211130102339.7C460385B83A@sourceware.org \ --to=aldyh@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).