From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1725) id E41623858403; Tue, 30 Nov 2021 23:20:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E41623858403 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: William Schmidt To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5646] rs6000: Clarify overloaded builtin diagnostic X-Act-Checkin: gcc X-Git-Author: Bill Schmidt X-Git-Refname: refs/heads/master X-Git-Oldrev: be30fc4ce085ef786f104c6a407ccd44e554cd54 X-Git-Newrev: 0fc26e6f0b5e5a40f2649e98db605f4c740e2c4e Message-Id: <20211130232056.E41623858403@sourceware.org> Date: Tue, 30 Nov 2021 23:20:56 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2021 23:20:57 -0000 https://gcc.gnu.org/g:0fc26e6f0b5e5a40f2649e98db605f4c740e2c4e commit r12-5646-g0fc26e6f0b5e5a40f2649e98db605f4c740e2c4e Author: Bill Schmidt Date: Tue Nov 23 10:22:58 2021 -0600 rs6000: Clarify overloaded builtin diagnostic When a built-in function required by an overloaded function name is not currently enabled, the diagnostic message is not as clear as it should be. Saying that one built-in "requires" another is somewhat misleading. It is better to explicitly state that the overloaded builtin is implemented by the missing builtin. 2021-11-23 Bill Schmidt gcc/ * config/rs6000/rs6000-c.c (altivec_resolve_overloaded_builtin): Clarify diagnostic. (altivec_resolve_new_overloaded_builtin): Likewise. Diff: --- gcc/config/rs6000/rs6000-c.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gcc/config/rs6000/rs6000-c.c b/gcc/config/rs6000/rs6000-c.c index d08bdfec3ae..5eeac9d4c06 100644 --- a/gcc/config/rs6000/rs6000-c.c +++ b/gcc/config/rs6000/rs6000-c.c @@ -1946,7 +1946,8 @@ altivec_resolve_overloaded_builtin (location_t loc, tree fndecl, non-overloaded function has already been issued. Add clarification of the previous message. */ rich_location richloc (line_table, input_location); - inform (&richloc, "builtin %qs requires builtin %qs", + inform (&richloc, + "overloaded builtin %qs is implemented by builtin %qs", name, internal_name); } else @@ -2992,7 +2993,8 @@ altivec_resolve_new_overloaded_builtin (location_t loc, tree fndecl, non-overloaded function has already been issued. Add clarification of the previous message. */ rich_location richloc (line_table, input_location); - inform (&richloc, "builtin %qs requires builtin %qs", + inform (&richloc, + "overloaded builtin %qs is implemented by builtin %qs", name, internal_name); } else