public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/aoliva/heads/testme)] [PR103097] tolerate reg-stack cross-block malformed asms Date: Sat, 4 Dec 2021 07:06:07 +0000 (GMT) [thread overview] Message-ID: <20211204070607.0519E3858D28@sourceware.org> (raw) https://gcc.gnu.org/g:9984f7a1b50d741a0adbf3e2cdcc9c1f5e5d59fc commit 9984f7a1b50d741a0adbf3e2cdcc9c1f5e5d59fc Author: Alexandre Oliva <oliva@adacore.com> Date: Sat Dec 4 03:49:32 2021 -0300 [PR103097] tolerate reg-stack cross-block malformed asms Diff: --- gcc/reg-stack.c | 3 +-- gcc/testsuite/gcc.target/i386/pr103097.c | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/gcc/reg-stack.c b/gcc/reg-stack.c index 1d9ea035cf4..a83ee253777 100644 --- a/gcc/reg-stack.c +++ b/gcc/reg-stack.c @@ -3014,8 +3014,6 @@ convert_regs_1 (basic_block block) bool cfg_altered = false; int debug_insns_with_starting_stack = 0; - any_malformed_asm = false; - /* Choose an initial stack layout, if one hasn't already been chosen. */ if (bi->stack_in.top == -2) { @@ -3385,6 +3383,7 @@ reg_to_stack (void) 0, sizeof (char) * (max_uid + 1)); convert_regs (); + any_malformed_asm = false; free_aux_for_blocks (); return true; diff --git a/gcc/testsuite/gcc.target/i386/pr103097.c b/gcc/testsuite/gcc.target/i386/pr103097.c new file mode 100644 index 00000000000..13ced3b42db --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr103097.c @@ -0,0 +1,21 @@ +/* { dg-do compile } */ +/* { dg-options "-O1 -fharden-conditional-branches" } */ + +/* This is a slightly simplified version of + gcc.target/s390/vector/long-double-asm-earlyclobber.c. On x86, the f + constraints in asm statements imposes some requirements that the testcase + doesn't meet. What's unusual is that -fharden-conditional-branches extends + the effects of the malformed asm onto a different basic blocks, which + reg-stack did not expect. */ + +#include <assert.h> +#include <stdint.h> + +int +main (void) +{ + long double res, x = 0; + asm("" : "=&f"(res) /* { dg-error "must specify a single register" } */ + : "f"(x)); + assert (res == x); +}
next reply other threads:[~2021-12-04 7:06 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-04 7:06 Alexandre Oliva [this message] 2021-12-04 9:22 Alexandre Oliva 2021-12-08 3:14 Alexandre Oliva
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211204070607.0519E3858D28@sourceware.org \ --to=aoliva@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).