From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1039) id A5AF5385842E; Tue, 7 Dec 2021 13:25:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A5AF5385842E MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: H.J. Lu To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5822] x86: Check FUNCTION_DECL before calling cgraph_node::get X-Act-Checkin: gcc X-Git-Author: H.J. Lu X-Git-Refname: refs/heads/master X-Git-Oldrev: 6e8a31275fda445fb3e8d98e53f5e1541f4727af X-Git-Newrev: 7ef68c37b3a46e69ed4a5ff6b2b368e2c9a8023f Message-Id: <20211207132516.A5AF5385842E@sourceware.org> Date: Tue, 7 Dec 2021 13:25:16 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2021 13:25:16 -0000 https://gcc.gnu.org/g:7ef68c37b3a46e69ed4a5ff6b2b368e2c9a8023f commit r12-5822-g7ef68c37b3a46e69ed4a5ff6b2b368e2c9a8023f Author: H.J. Lu Date: Tue Dec 7 05:09:34 2021 -0800 x86: Check FUNCTION_DECL before calling cgraph_node::get gcc/ PR target/103594 * config/i386/i386.c (ix86_call_use_plt_p): Check FUNCTION_DECL before calling cgraph_node::get. gcc/testsuite/ PR target/103594 * gcc.dg/pr103594.c: New test. Diff: --- gcc/config/i386/i386.c | 3 ++- gcc/testsuite/gcc.dg/pr103594.c | 14 ++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 52547b0f057..f1e41fd55f9 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -15987,7 +15987,8 @@ ix86_call_use_plt_p (rtx call_op) { if (SYMBOL_REF_LOCAL_P (call_op)) { - if (SYMBOL_REF_DECL (call_op)) + if (SYMBOL_REF_DECL (call_op) + && TREE_CODE (SYMBOL_REF_DECL (call_op)) == FUNCTION_DECL) { /* NB: All ifunc functions must be called via PLT. */ cgraph_node *node diff --git a/gcc/testsuite/gcc.dg/pr103594.c b/gcc/testsuite/gcc.dg/pr103594.c new file mode 100644 index 00000000000..0eae239eea0 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr103594.c @@ -0,0 +1,14 @@ +/* { dg-do compile { target fpic } } */ +/* { dg-options "-O1 -fpic" } */ + +int regex_subst(void) +{ + const void *subst = ""; + return (*(int (*)(int))subst) (0); +} + +int foobar (void) +{ + int x; + return (*(int (*)(void))&x) (); +}