From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7824) id 270503858003; Wed, 8 Dec 2021 18:48:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 270503858003 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: David Faust To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5843] bpf: avoid potential NULL pointer dereference X-Act-Checkin: gcc X-Git-Author: David Faust X-Git-Refname: refs/heads/master X-Git-Oldrev: 5f7cdea34e118776d0ccd2ff3dda0f5acab18a94 X-Git-Newrev: e4c2b55b4cefc574a4c2b0b06928220edb9b3f2c Message-Id: <20211208184850.270503858003@sourceware.org> Date: Wed, 8 Dec 2021 18:48:50 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 18:48:50 -0000 https://gcc.gnu.org/g:e4c2b55b4cefc574a4c2b0b06928220edb9b3f2c commit r12-5843-ge4c2b55b4cefc574a4c2b0b06928220edb9b3f2c Author: David Faust Date: Tue Dec 7 11:45:48 2021 -0800 bpf: avoid potential NULL pointer dereference If the result from SSA_NAME_DEF_STMT is NULL, we could try to dereference it anyway and ICE. Avoid this. gcc/ChangeLog: * config/bpf/bpf.c (handle_attr_preserve): Avoid calling is_gimple_assign with a NULL pointer. Diff: --- gcc/config/bpf/bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/bpf/bpf.c b/gcc/config/bpf/bpf.c index 9d2c0bb6818..c054c1ead6b 100644 --- a/gcc/config/bpf/bpf.c +++ b/gcc/config/bpf/bpf.c @@ -1482,7 +1482,7 @@ handle_attr_preserve (function *fn) && TREE_CODE (TREE_OPERAND (expr, 0)) == SSA_NAME) { gimple *def_stmt = SSA_NAME_DEF_STMT (TREE_OPERAND (expr, 0)); - if (is_gimple_assign (def_stmt)) + if (def_stmt && is_gimple_assign (def_stmt)) expr = gimple_assign_rhs1 (def_stmt); }