From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2071) id 49EF23858D3C; Wed, 8 Dec 2021 20:15:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 49EF23858D3C MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Harald Anlauf To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-5847] Fortran: avoid NULL pointer dereference on missing or bad dummy arguments X-Act-Checkin: gcc X-Git-Author: Harald Anlauf X-Git-Refname: refs/heads/master X-Git-Oldrev: 7add7f7bb3d35726a0c45322ffdbbab2bbf6a348 X-Git-Newrev: b77968a70537429b4f548f90c369d26e6b6943cc Message-Id: <20211208201545.49EF23858D3C@sourceware.org> Date: Wed, 8 Dec 2021 20:15:45 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 20:15:45 -0000 https://gcc.gnu.org/g:b77968a70537429b4f548f90c369d26e6b6943cc commit r12-5847-gb77968a70537429b4f548f90c369d26e6b6943cc Author: Harald Anlauf Date: Wed Dec 8 21:14:19 2021 +0100 Fortran: avoid NULL pointer dereference on missing or bad dummy arguments gcc/fortran/ChangeLog: PR fortran/103609 * symbol.c (gfc_sym_get_dummy_args): Catch NULL pointer dereference. gcc/testsuite/ChangeLog: PR fortran/103609 * gfortran.dg/pr103609.f90: New test. Diff: --- gcc/fortran/symbol.c | 3 +++ gcc/testsuite/gfortran.dg/pr103609.f90 | 15 +++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/gcc/fortran/symbol.c b/gcc/fortran/symbol.c index 179f6029ca3..ebd99846610 100644 --- a/gcc/fortran/symbol.c +++ b/gcc/fortran/symbol.c @@ -5240,6 +5240,9 @@ gfc_sym_get_dummy_args (gfc_symbol *sym) { gfc_formal_arglist *dummies; + if (sym == NULL) + return NULL; + dummies = sym->formal; if (dummies == NULL && sym->ts.interface != NULL) dummies = sym->ts.interface->formal; diff --git a/gcc/testsuite/gfortran.dg/pr103609.f90 b/gcc/testsuite/gfortran.dg/pr103609.f90 new file mode 100644 index 00000000000..57f6a3b1531 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr103609.f90 @@ -0,0 +1,15 @@ +! { dg-do compile } +! PR fortran/103609 - ICE in gfc_sym_get_dummy_args +! Contributed by G.Steinmetz + +program p + implicit none + integer :: i + do i = 1, 2 + call s + end do +contains + subroutine s + call sub(x) ! { dg-error "has no IMPLICIT type" } + end +end