From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1363) id 322BF3858C2C; Mon, 3 Jan 2022 19:59:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 322BF3858C2C MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" From: Uros Bizjak To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-6194] i386: Always enable mov patterns [PR103894] X-Act-Checkin: gcc X-Git-Author: Uros Bizjak X-Git-Refname: refs/heads/master X-Git-Oldrev: 122a75488c98b898df1a6f2ed4e48836a5d72d7a X-Git-Newrev: 1096ab1775636f35de9c6661f8f71f03299af998 Message-Id: <20220103195934.322BF3858C2C@sourceware.org> Date: Mon, 3 Jan 2022 19:59:34 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jan 2022 19:59:34 -0000 https://gcc.gnu.org/g:1096ab1775636f35de9c6661f8f71f03299af998 commit r12-6194-g1096ab1775636f35de9c6661f8f71f03299af998 Author: Uros Bizjak Date: Mon Jan 3 20:58:16 2022 +0100 i386: Always enable mov patterns [PR103894] Middle end tries to generate V4QImode moves to implement V2QImode inserts and calls emit_move_multi_word when V4QImode moves are unavailable, as is the case with 32-bit vector moves, constrainted with TARGET_SSE2. However, this triggers gcc_assert (mode_size >= UNITS_PER_WORD); in emit_move_multi_word, since mode_size of V4QImode operand is less than UNITS_PER_WORD of 64-bit targets. The patch unconditionally enables 32-bit vector moves to match 16-bit vector moves. This also enables implementation of 32-bit vector logic operations with GPR in a follow-up patch. 2022-01-03 Uroš Bizjak gcc/ChangeLog: PR target/103894 * config/i386/mmx.md (mov): Remove TARGET_SSE2 constraint. (mov_internal): Ditto. (*push_rex64): Ditto. (movmisalign): Ditto. (*push_rex64 splitter): Enable for TARGET_64BIT && TARGET_SSE. (*push2): Remove insn pattern. gcc/testsuite/ChangeLog: PR target/103894 * gcc.target/i386/pr103894.c: New test. Diff: --- gcc/config/i386/mmx.md | 23 ++++++----------------- gcc/testsuite/gcc.target/i386/pr103894.c | 13 +++++++++++++ 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md index 67b02661243..5b33d3cfc1c 100644 --- a/gcc/config/i386/mmx.md +++ b/gcc/config/i386/mmx.md @@ -250,7 +250,7 @@ (define_expand "mov" [(set (match_operand:V_32 0 "nonimmediate_operand") (match_operand:V_32 1 "nonimmediate_operand"))] - "TARGET_SSE2" + "" { ix86_expand_vector_move (mode, operands); DONE; @@ -261,8 +261,7 @@ "=r ,m ,v,v,v,m,r,v") (match_operand:V_32 1 "general_operand" "rmC,rC,C,v,m,v,v,r"))] - "TARGET_SSE2 - && !(MEM_P (operands[0]) && MEM_P (operands[1]))" + "!(MEM_P (operands[0]) && MEM_P (operands[1]))" { switch (get_attr_type (insn)) { @@ -321,29 +320,19 @@ (define_insn "*push2_rex64" [(set (match_operand:V_32 0 "push_operand" "=X,X") (match_operand:V_32 1 "nonmemory_no_elim_operand" "rC,*v"))] - "TARGET_SSE2 && TARGET_64BIT" + "TARGET_64BIT" "@ push{q}\t%q1 #" [(set_attr "type" "push,multi") (set_attr "mode" "DI")]) -(define_insn "*push2" - [(set (match_operand:V_32 0 "push_operand" "=<,<") - (match_operand:V_32 1 "general_no_elim_operand" "rC*m,*v"))] - "TARGET_SSE2 && !TARGET_64BIT" - "@ - push{l}\t%1 - #" - [(set_attr "type" "push,multi") - (set_attr "mode" "SI")]) - (define_split [(set (match_operand:V_32 0 "push_operand") (match_operand:V_32 1 "sse_reg_operand"))] - "TARGET_SSE2 && reload_completed" + "TARGET_64BIT && TARGET_SSE && reload_completed" [(set (reg:P SP_REG) (plus:P (reg:P SP_REG) (match_dup 2))) - (set (match_dup 0) (match_dup 1))] + (set (match_dup 0) (match_dup 1))] { operands[2] = GEN_INT (-PUSH_ROUNDING (GET_MODE_SIZE (mode))); /* Preserve memory attributes. */ @@ -353,7 +342,7 @@ (define_expand "movmisalign" [(set (match_operand:V_32 0 "nonimmediate_operand") (match_operand:V_32 1 "nonimmediate_operand"))] - "TARGET_SSE2" + "" { ix86_expand_vector_move (mode, operands); DONE; diff --git a/gcc/testsuite/gcc.target/i386/pr103894.c b/gcc/testsuite/gcc.target/i386/pr103894.c new file mode 100644 index 00000000000..69c81046930 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr103894.c @@ -0,0 +1,13 @@ +/* PR target/103894 */ +/* { dg-do compile } */ +/* { dg-options "-msse -mno-sse2" } */ + +typedef unsigned char __attribute__((__vector_size__ (32))) V; +typedef unsigned char __attribute__((__vector_size__ (2))) W; + +V v; + +W foo (W w) +{ + return __builtin_shufflevector (v, w, 3, 4); +}