From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2152) id DF9763858416; Wed, 12 Jan 2022 02:51:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DF9763858416 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Hans-Peter Nilsson To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-6511] cris: Parenthesize parameter to as_a. X-Act-Checkin: gcc X-Git-Author: Hans-Peter Nilsson X-Git-Refname: refs/heads/master X-Git-Oldrev: 01a254e3e53cc1cf9e16688ed785ca931b1459aa X-Git-Newrev: f8feccb8b08a42fa44caff69c8d82860caef3574 Message-Id: <20220112025142.DF9763858416@sourceware.org> Date: Wed, 12 Jan 2022 02:51:42 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jan 2022 02:51:43 -0000 https://gcc.gnu.org/g:f8feccb8b08a42fa44caff69c8d82860caef3574 commit r12-6511-gf8feccb8b08a42fa44caff69c8d82860caef3574 Author: Hans-Peter Nilsson Date: Wed Jan 12 02:07:13 2022 +0100 cris: Parenthesize parameter to as_a. Noted by Richard Sandiford in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103974#c7 (thanks!) Mea culpa: I wrongly thought the default development-level value ("yes,extra") would include everything interesting to normal target hacking (i.e. as opposed to hacking stuff like GC). I see rtl-checking is marked as "expensive" and presumably therefore left out. Maybe it could be split into rtl-static (cheap; catching type errors including this kind of foulups) and rtl-dynamic (the expensive parts). I suppose that's for whomever feels a strong enough itch. A quick (error-prone) grep-and-eyeball in config/ shows this was the only file missing the parenthesis. This lets cris-elf configured with --enable-checking=yes,extra,rtl survive make all-gcc. 2022-01-11 Hans-Peter Nilsson * config/cris/cris.c (cris_postdbr_cmpelim): Parenthesize parameter to as_a. Diff: --- gcc/config/cris/cris.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/cris/cris.c b/gcc/config/cris/cris.c index eff58435789..ac1fc4909fc 100644 --- a/gcc/config/cris/cris.c +++ b/gcc/config/cris/cris.c @@ -392,7 +392,7 @@ cris_postdbr_cmpelim () /* Consider filled delay slots; there might be a comparison there. It's only the second insn in a sequence that is interesting. */ if (GET_CODE (pat) == SEQUENCE) - insn = as_a XVECEXP (pat, 0, 1); + insn = as_a (XVECEXP (pat, 0, 1)); /* The "else" eliminates temptations to consider an insn in a delay slot for elimination; it can only be a prev_cc_setter. */ else if (prev_cc_setter != 0 && GET_CODE (pat) == SET)