public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-6550] inliner: Don't emit copy stmts for empty type parameters [PR103989]
Date: Thu, 13 Jan 2022 15:01:19 +0000 (GMT)	[thread overview]
Message-ID: <20220113150119.7628C3951C2F@sourceware.org> (raw)

https://gcc.gnu.org/g:53ead5787921be799593232cfc9931f916b79002

commit r12-6550-g53ead5787921be799593232cfc9931f916b79002
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jan 13 15:59:47 2022 +0100

    inliner: Don't emit copy stmts for empty type parameters [PR103989]
    
    The following patch avoids emitting a parameter copy statement when inlining
    if the parameter has empty type.  E.g. the gimplifier does something similar
    (except that it needs to evaluate side-effects if any, which isn't the case
    here):
      /* For empty types only gimplify the left hand side and right hand
         side as statements and throw away the assignment.  Do this after
         gimplify_modify_expr_rhs so we handle TARGET_EXPRs of addressable
         types properly.  */
      if (is_empty_type (TREE_TYPE (*from_p))
          && !want_value
          /* Don't do this for calls that return addressable types, expand_call
             relies on those having a lhs.  */
          && !(TREE_ADDRESSABLE (TREE_TYPE (*from_p))
               && TREE_CODE (*from_p) == CALL_EXPR))
        {
          gimplify_stmt (from_p, pre_p);
          gimplify_stmt (to_p, pre_p);
          *expr_p = NULL_TREE;
          return GS_ALL_DONE;
        }
    Unfortunately, this patch doesn't cure the uninit warnings in that PR,
    which is caused by ipa inlining happening even at -Og when the post-IPA
    -Og passes don't expect the need to clean up after ipa inlining,
    but I think is desirable anyway.
    
    2022-01-13  Jakub Jelinek  <jakub@redhat.com>
    
            PR tree-optimization/103989
            * tree-inline.c (setup_one_parameter): Don't copy parms with
            empty type.

Diff:
---
 gcc/tree-inline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/tree-inline.c b/gcc/tree-inline.c
index d7fc33eb055..8ea8de7e7cb 100644
--- a/gcc/tree-inline.c
+++ b/gcc/tree-inline.c
@@ -3608,7 +3608,7 @@ setup_one_parameter (copy_body_data *id, tree p, tree value, tree fn,
 	      init_stmt = gimple_build_assign (def, rhs);
 	    }
 	}
-      else
+      else if (!is_empty_type (TREE_TYPE (var)))
         init_stmt = gimple_build_assign (var, rhs);
 
       if (bb && init_stmt)


                 reply	other threads:[~2022-01-13 15:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220113150119.7628C3951C2F@sourceware.org \
    --to=jakub@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).