From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2122) id 131BA3858C60; Fri, 21 Jan 2022 17:06:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 131BA3858C60 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jason Merrill To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-6800] c++: [[no_unique_address]] and virtual base [PR104139] X-Act-Checkin: gcc X-Git-Author: Jason Merrill X-Git-Refname: refs/heads/master X-Git-Oldrev: 45cae5b6392496028f35c5948f7fae0af81d135b X-Git-Newrev: 23be9f83bbd2c6f03580757adbfe599de6bf702b Message-Id: <20220121170646.131BA3858C60@sourceware.org> Date: Fri, 21 Jan 2022 17:06:46 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2022 17:06:46 -0000 https://gcc.gnu.org/g:23be9f83bbd2c6f03580757adbfe599de6bf702b commit r12-6800-g23be9f83bbd2c6f03580757adbfe599de6bf702b Author: Jason Merrill Date: Fri Jan 21 11:16:49 2022 -0500 c++: [[no_unique_address]] and virtual base [PR104139] Fixing a thinko in my patch for 103681: when computing the size of a virtual base, it would help to use its binfo instead of the one for the derived class. PR c++/104139 PR c++/103681 gcc/cp/ChangeLog: * class.cc (end_of_class): Use base_binfo. gcc/testsuite/ChangeLog: * g++.dg/abi/no_unique_address2.C: Adjust to detect this on x86-64. Diff: --- gcc/cp/class.cc | 4 ++-- gcc/testsuite/g++.dg/abi/no_unique_address2.C | 27 +++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/gcc/cp/class.cc b/gcc/cp/class.cc index e5cc6f10e3b..5db3722ae46 100644 --- a/gcc/cp/class.cc +++ b/gcc/cp/class.cc @@ -6414,8 +6414,8 @@ end_of_class (tree t, eoc_mode mode) { if (mode == eoc_nv_or_dsize) /* For dsize, don't count trailing empty bases. */ - offset = size_binop (PLUS_EXPR, BINFO_OFFSET (binfo), - CLASSTYPE_SIZE_UNIT (BINFO_TYPE (binfo))); + offset = size_binop (PLUS_EXPR, BINFO_OFFSET (base_binfo), + CLASSTYPE_SIZE_UNIT (BINFO_TYPE (base_binfo))); else offset = end_of_base (base_binfo); if (tree_int_cst_lt (result, offset)) diff --git a/gcc/testsuite/g++.dg/abi/no_unique_address2.C b/gcc/testsuite/g++.dg/abi/no_unique_address2.C index bef6d5b43be..3bb3f76ac92 100644 --- a/gcc/testsuite/g++.dg/abi/no_unique_address2.C +++ b/gcc/testsuite/g++.dg/abi/no_unique_address2.C @@ -41,3 +41,30 @@ struct B4 #define SA(X) static_assert ((X), #X) SA (sizeof (B2) == sizeof (B1)); SA (sizeof (B3) == sizeof (B4)); + +namespace N2 +{ + // C as big as _vptr to test PR c++/104139 + struct C + { + long c; + }; + + struct D: virtual C + { + virtual void f(); + }; + + struct B3: D + { + char c2; + }; + + struct B4 + { + D d [[no_unique_address]]; + char c2; + }; + + SA (sizeof (B3) == sizeof (B4)); +}