public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Martin Liska <marxin@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/marxin/heads/internal_error-wording)] internal_error - do not use leading capital letter
Date: Thu, 27 Jan 2022 12:53:56 +0000 (GMT)	[thread overview]
Message-ID: <20220127125356.6FBF6394742C@sourceware.org> (raw)

https://gcc.gnu.org/g:333c2061fc785ea314717db90635fa9c013c56f7

commit 333c2061fc785ea314717db90635fa9c013c56f7
Author: Martin Liska <mliska@suse.cz>
Date:   Thu Jan 27 13:37:04 2022 +0100

    internal_error - do not use leading capital letter
    
    gcc/ChangeLog:
    
            * config/rs6000/host-darwin.cc (segv_crash_handler):
            Do not use leading capital letter.
            (segv_handler): Likewise.
            * ipa-sra.cc (verify_splitting_accesses): Likewise.
            * varasm.cc (get_section): Likewise.
    
    gcc/d/ChangeLog:
    
            * decl.cc (d_finish_decl): Do not use leading capital letter.

Diff:
---
 gcc/config/rs6000/host-darwin.cc | 4 ++--
 gcc/d/decl.cc                    | 2 +-
 gcc/ipa-sra.cc                   | 4 ++--
 gcc/varasm.cc                    | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/gcc/config/rs6000/host-darwin.cc b/gcc/config/rs6000/host-darwin.cc
index 541f7e1c81c..6072a6cddc4 100644
--- a/gcc/config/rs6000/host-darwin.cc
+++ b/gcc/config/rs6000/host-darwin.cc
@@ -58,7 +58,7 @@ extern int sigaltstack(const struct sigaltstack *, struct sigaltstack *);
 static void
 segv_crash_handler (int sig ATTRIBUTE_UNUSED)
 {
-  internal_error ("Segmentation Fault (code)");
+  internal_error ("segmentation fault (code)");
 }
 
 static void
@@ -128,7 +128,7 @@ segv_handler (int sig ATTRIBUTE_UNUSED,
   fprintf (stderr, "[address=%08lx pc=%08x]\n", 
 	   uc->uc_mcontext->MC_FLD(es).MC_FLD(dar),
 	   uc->uc_mcontext->MC_FLD(ss).MC_FLD(srr0));
-  internal_error ("Segmentation Fault");
+  internal_error ("segmentation fault");
   exit (FATAL_EXIT_CODE);
 }
 
diff --git a/gcc/d/decl.cc b/gcc/d/decl.cc
index c7a1e4652f8..5ecc6269780 100644
--- a/gcc/d/decl.cc
+++ b/gcc/d/decl.cc
@@ -1597,7 +1597,7 @@ d_finish_decl (tree decl)
 	{
 	  tree name = DECL_ASSEMBLER_NAME (decl);
 
-	  internal_error ("Mismatch between declaration %qE size (%wd) and "
+	  internal_error ("mismatch between declaration %qE size (%wd) and "
 			  "its initializer size (%wd).",
 			  IDENTIFIER_PRETTY_NAME (name)
 			  ? IDENTIFIER_PRETTY_NAME (name) : name,
diff --git a/gcc/ipa-sra.cc b/gcc/ipa-sra.cc
index 969160f9806..f8a4549c9b0 100644
--- a/gcc/ipa-sra.cc
+++ b/gcc/ipa-sra.cc
@@ -2493,10 +2493,10 @@ verify_splitting_accesses (cgraph_node *node, bool certain_must_exist)
 
       bool certain_access_present = !certain_must_exist;
       if (overlapping_certain_accesses_p (desc, &certain_access_present))
-	internal_error ("Function %qs, parameter %u, has IPA-SRA accesses "
+	internal_error ("function %qs, parameter %u, has IPA-SRA accesses "
 			"which overlap", node->dump_name (), pidx);
       if (!certain_access_present)
-	internal_error ("Function %s, parameter %u, is used but does not "
+	internal_error ("function %qs, parameter %u, is used but does not "
 			"have any certain IPA-SRA access",
 			node->dump_name (), pidx);
     }
diff --git a/gcc/varasm.cc b/gcc/varasm.cc
index 5bc30f0c26e..330ec293711 100644
--- a/gcc/varasm.cc
+++ b/gcc/varasm.cc
@@ -312,7 +312,7 @@ get_section (const char *name, unsigned int flags, tree decl,
   else
     {
       if (not_existing)
-	internal_error ("Section already exists: %qs", name);
+	internal_error ("section already exists: %qs", name);
 
       sect = *slot;
       /* It is fine if one of the sections has SECTION_NOTYPE as long as


             reply	other threads:[~2022-01-27 12:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 12:53 Martin Liska [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-01-27 12:38 Martin Liska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220127125356.6FBF6394742C@sourceware.org \
    --to=marxin@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).