From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1005) id 2E21F3858418; Fri, 28 Jan 2022 17:37:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E21F3858418 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Michael Meissner To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/meissner/heads/work077)] Use correct names for __ibm128 if long double is IEEE 128-bit. X-Act-Checkin: gcc X-Git-Author: Michael Meissner X-Git-Refname: refs/users/meissner/heads/work077 X-Git-Oldrev: 88198f18915687e4f0a3f20b34acca54174be5ad X-Git-Newrev: 964b43e585c69a9555f2b25066962e0c3bab3b95 Message-Id: <20220128173706.2E21F3858418@sourceware.org> Date: Fri, 28 Jan 2022 17:37:06 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 17:37:06 -0000 https://gcc.gnu.org/g:964b43e585c69a9555f2b25066962e0c3bab3b95 commit 964b43e585c69a9555f2b25066962e0c3bab3b95 Author: Michael Meissner Date: Fri Jan 28 12:36:49 2022 -0500 Use correct names for __ibm128 if long double is IEEE 128-bit. If you are on a PowerPC system where the default long double is IEEE 128-bit, GCC will use the wrong names for some of the conversion functions for the __ibm128 type. What is happening is when the defult long double is IEEE 128-bit, the various convert, truncation, and extend functions did not specify a default name for the conversion. The machine indepentent portions of the compiler would construct a call with an 'if' name (IFmode being the mode for IBM 128-bit floating point). This patch specifies to use the tradiational 'tf' name for these conversion functions. 2022-01-28 Michael Meissner gcc/ PR target/104253 * config/rs6000/rs6000.cc (TARGET_IEEEQUAD_DEFAULT): If the compiler used to build the current compiler defaults to IEEE 128-bit long double, make that the default for this build. gcc/testsuite/ PR target/104253 * gcc.target/powerpc/pr104253.c: New test. Diff: --- gcc/config/rs6000/rs6000.cc | 18 ++++ gcc/testsuite/gcc.target/powerpc/pr104253.c | 154 ++++++++++++++++++++++++++++ 2 files changed, 172 insertions(+) diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index f5c089a2a26..4fa0540c6af 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -11106,6 +11106,14 @@ init_float128_ibm (machine_mode mode) names. */ if (mode == IFmode) { + set_conv_libfunc (sext_optab, mode, SFmode, "__extendsftf2"); + set_conv_libfunc (sext_optab, mode, DFmode, "__extenddftf2"); + set_conv_libfunc (trunc_optab, SFmode, mode, "__trunctfsf2"); + set_conv_libfunc (trunc_optab, DFmode, mode, "__trunctfdf2"); + + set_conv_libfunc (sext_optab, mode, IFmode, "__trunctftf2"); + set_conv_libfunc (trunc_optab, IFmode, mode, "__extendtftf2"); + set_conv_libfunc (sext_optab, mode, SDmode, "__dpd_extendsdtf"); set_conv_libfunc (sext_optab, mode, DDmode, "__dpd_extendddtf"); set_conv_libfunc (trunc_optab, mode, TDmode, "__dpd_trunctdtf"); @@ -11113,6 +11121,16 @@ init_float128_ibm (machine_mode mode) set_conv_libfunc (trunc_optab, DDmode, mode, "__dpd_trunctfdd"); set_conv_libfunc (sext_optab, TDmode, mode, "__dpd_extendtftd"); + set_conv_libfunc (sfix_optab, SImode, mode, "__fixtfsi"); + set_conv_libfunc (ufix_optab, SImode, mode, "__fixunstfsi"); + set_conv_libfunc (sfix_optab, DImode, mode, "__fixtfdi"); + set_conv_libfunc (ufix_optab, DImode, mode, "__fixunstfdi"); + + set_conv_libfunc (sfloat_optab, mode, SImode, "__floatsitf"); + set_conv_libfunc (ufloat_optab, mode, SImode, "__floatunsitf"); + set_conv_libfunc (sfloat_optab, mode, DImode, "__floatditf"); + set_conv_libfunc (ufloat_optab, mode, DImode, "__floatunditf"); + if (TARGET_POWERPC64) { set_conv_libfunc (sfix_optab, TImode, mode, "__fixtfti"); diff --git a/gcc/testsuite/gcc.target/powerpc/pr104253.c b/gcc/testsuite/gcc.target/powerpc/pr104253.c new file mode 100644 index 00000000000..a1e73fe012c --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr104253.c @@ -0,0 +1,154 @@ +/* + * Require float128 support because __ibm128 currently is not enabled unless we + * also have __float128 support. + */ + +/* { dg-do run } */ +/* { require-effective-target ppc_float128_sw } */ +/* { dg-options "-O2 -mvsx -mfloat128" } */ + +/* + * PR target/104253 + * + * Verify that the various conversions to and from __ibm128 work. When the + * default for long double is changed to IEEE 128-bit, originally GCC would + * call the functions using an 'if' name instead of 'tf. + */ + +#include + +extern float ibm128_to_sf (__ibm128) __attribute__((noinline)); +extern double ibm128_to_df (__ibm128) __attribute__((noinline)); +extern int ibm128_to_si (__ibm128) __attribute__((noinline)); +extern long long ibm128_to_di (__ibm128) __attribute__((noinline)); +extern unsigned int ibm128_to_usi (__ibm128) __attribute__((noinline)); +extern unsigned long long ibm128_to_udi (__ibm128) __attribute__((noinline)); + +extern __ibm128 sf_to_ibm128 (float) __attribute__((noinline)); +extern __ibm128 df_to_ibm128 (double) __attribute__((noinline)); +extern __ibm128 si_to_ibm128 (int) __attribute__((noinline)); +extern __ibm128 di_to_ibm128 (long long) __attribute__((noinline)); +extern __ibm128 usi_to_ibm128 (unsigned int) __attribute__((noinline)); +extern __ibm128 udi_to_ibm128 (unsigned long long) __attribute__((noinline)); + +float +ibm128_to_sf (__ibm128 x) +{ + return x; +} + +double +ibm128_to_df (__ibm128 x) +{ + return x; +} + +int +ibm128_to_si (__ibm128 x) +{ + return x; +} + +long long +ibm128_to_di (__ibm128 x) +{ + return x; +} + +unsigned int +ibm128_to_usi (__ibm128 x) +{ + return x; +} + +unsigned long long +ibm128_to_udi (__ibm128 x) +{ + return x; +} + +__ibm128 +sf_to_ibm128 (float x) +{ + return x; +} + +__ibm128 +df_to_ibm128 (double x) +{ + return x; +} + +__ibm128 +si_to_ibm128 (int x) +{ + return x; +} + +__ibm128 +di_to_ibm128 (long long x) +{ + return x; +} + +__ibm128 +usi_to_ibm128 (unsigned int x) +{ + return x; +} + +__ibm128 +udi_to_ibm128 (unsigned long long x) +{ + return x; +} + +volatile float seven_sf = 7.0f; +volatile double seven_df = 7.0; +volatile int seven_si = 7; +volatile long long seven_di = 7LL; +volatile unsigned int seven_usi = 7U; +volatile unsigned long long seven_udi = 7ULL; +volatile __ibm128 seven_ibm128 = 7.0; + +int +main (void) +{ + if (seven_ibm128 != sf_to_ibm128 (seven_sf)) + abort (); + + if (seven_ibm128 != df_to_ibm128 (seven_df)) + abort (); + + if (seven_ibm128 != si_to_ibm128 (seven_si)) + abort (); + + if (seven_ibm128 != di_to_ibm128 (seven_di)) + abort (); + + if (seven_ibm128 != usi_to_ibm128 (seven_usi)) + abort (); + + if (seven_ibm128 != udi_to_ibm128 (seven_udi)) + abort (); + + if (seven_sf != ibm128_to_sf (seven_ibm128)) + abort (); + + if (seven_df != ibm128_to_df (seven_ibm128)) + abort (); + + if (seven_si != ibm128_to_si (seven_ibm128)) + abort (); + + if (seven_di != ibm128_to_di (seven_ibm128)) + abort (); + + if (seven_usi != ibm128_to_usi (seven_ibm128)) + abort (); + + if (seven_udi != ibm128_to_udi (seven_ibm128)) + abort (); + + return 0; +}