public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-6957] [libgomp, testsuite] Reduce recursion depth in declare_target-*.f90
Date: Tue,  1 Feb 2022 07:19:39 +0000 (GMT)	[thread overview]
Message-ID: <20220201071939.26BDC3857C64@sourceware.org> (raw)

https://gcc.gnu.org/g:be362d5e127e087dcd4a2c0d843cf7b9a7399c73

commit r12-6957-gbe362d5e127e087dcd4a2c0d843cf7b9a7399c73
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Jan 20 13:37:08 2022 +0100

    [libgomp, testsuite] Reduce recursion depth in declare_target-*.f90
    
    When running the libgomp testsuite with GOMP_NVPTX_JIT=-O0 using an nvptx
    accelerator (Nvidia T400, 2GB), I run into:
    ...
    libgomp: cuCtxSynchronize error: unspecified launch failure \
      (perhaps abort was called)
    
    libgomp: cuMemFree_v2 error: unspecified launch failure
    
    libgomp: device finalization failed
    FAIL: libgomp.fortran/examples-4/declare_target-1.f90   -O0  execution test
    ...
    
    The test-case contains:
    ...
      ! Reduced from 25 to 23, otherwise execution runs out of thread stack on
      ! Nvidia Titan V.
      if (fib (23) /= fib_wrapper (23)) stop 2
    ...
    
    Fix this by reducing the fib/fib_wrapper argument from 23 to 22.
    
    Same for declare_target-2.f90.
    
    Tested on x86_64 with nvptx accelerator.
    
    libgomp/ChangeLog:
    
    2022-01-27  Tom de Vries  <tdevries@suse.de>
    
            * testsuite/libgomp.fortran/examples-4/declare_target-1.f90: Reduce
            recursion depth.
            * testsuite/libgomp.fortran/examples-4/declare_target-2.f90: Same.

Diff:
---
 libgomp/testsuite/libgomp.fortran/examples-4/declare_target-1.f90 | 4 +++-
 libgomp/testsuite/libgomp.fortran/examples-4/declare_target-2.f90 | 6 ++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-1.f90 b/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-1.f90
index e439fe1b738..b761979ecde 100644
--- a/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-1.f90
+++ b/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-1.f90
@@ -29,5 +29,7 @@ program e_53_1
   if (fib (15) /= fib_wrapper (15)) stop 1
   ! Reduced from 25 to 23, otherwise execution runs out of thread stack on
   ! Nvidia Titan V.
-  if (fib (23) /= fib_wrapper (23)) stop 2
+  ! Reduced from 23 to 22, otherwise execution runs out of thread stack on
+  ! Nvidia T400 (2GB variant), when run with GOMP_NVPTX_JIT=-O0.
+  if (fib (22) /= fib_wrapper (22)) stop 2
 end program
diff --git a/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-2.f90 b/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-2.f90
index ee582b21632..f576c25ba39 100644
--- a/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-2.f90
+++ b/libgomp/testsuite/libgomp.fortran/examples-4/declare_target-2.f90
@@ -6,9 +6,11 @@ program e_53_2
   !$omp target map(from: x)
     ! Reduced from 25 to 23, otherwise execution runs out of thread stack on
     ! Nvidia Titan V.
-    x = fib (23)
+    ! Reduced from 23 to 22, otherwise execution runs out of thread stack on
+    ! Nvidia T400 (2GB variant), when run with GOMP_NVPTX_JIT=-O0.
+    x = fib (22)
   !$omp end target
-  if (x /= fib (23)) stop 1
+  if (x /= fib (22)) stop 1
 end program
 
 integer recursive function fib (n) result (f)


                 reply	other threads:[~2022-02-01  7:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220201071939.26BDC3857C64@sourceware.org \
    --to=vries@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).