public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Eugene Rozenfeld <erozen@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-6984] AutoFDO: don't set param_early_inliner_max_iterations to 10. Date: Tue, 1 Feb 2022 23:20:38 +0000 (GMT) [thread overview] Message-ID: <20220201232038.182E43858437@sourceware.org> (raw) https://gcc.gnu.org/g:c17975d81aaed49ff759c20c68b31304a6953d58 commit r12-6984-gc17975d81aaed49ff759c20c68b31304a6953d58 Author: Eugene Rozenfeld <erozen@microsoft.com> Date: Tue Jan 18 16:03:19 2022 -0800 AutoFDO: don't set param_early_inliner_max_iterations to 10. param_early_inliner_max_iterations specifies the maximum number of nested indirect inlining iterations performed by early inliner. Normally, the default value is 1. For AutoFDO this parameter was also used as the number of iteration for its indirect call promotion loop and the default value was set to 10. While it makes sense to have 10 in the indirect call promotion loop (we want to make the IR match the profiled binary before actual annotation) there is no reason to have a special default value for the regular early inliner. This change removes the special AutoFDO default value setting for param_early_inliner_max_iterations while keeping 10 as the number of iterations for the AutoFDO indirect call promotion loop. This change improves a simple fibonacci benchmark in AutoFDO mode by 15% on x86_64-pc-linux-gnu. Tested on x86_64-pc-linux-gnu. gcc/ChangeLog: * auto-profile.cc (auto_profile): Hard-code the number of iterations (10). gcc/ChangeLog: * opts.cc (common_handle_option): Don't set param_early_inliner_max_iterations to 10 for AutoFDO. Diff: --- gcc/auto-profile.cc | 3 +-- gcc/opts.cc | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/gcc/auto-profile.cc b/gcc/auto-profile.cc index 0bfaae7b091..c7cee639c85 100644 --- a/gcc/auto-profile.cc +++ b/gcc/auto-profile.cc @@ -1644,8 +1644,7 @@ auto_profile (void) function before annotation, so the profile inside bar@loc_foo2 will be useful. */ autofdo::stmt_set promoted_stmts; - for (int i = 0; i < opt_for_fn (node->decl, - param_early_inliner_max_iterations); i++) + for (int i = 0; i < 10; i++) { if (!flag_value_profile_transformations || !autofdo::afdo_vpt_for_early_inline (&promoted_stmts)) diff --git a/gcc/opts.cc b/gcc/opts.cc index 7d30deb8e4b..6e2ee821c44 100644 --- a/gcc/opts.cc +++ b/gcc/opts.cc @@ -2895,8 +2895,6 @@ common_handle_option (struct gcc_options *opts, case OPT_fauto_profile: enable_fdo_optimizations (opts, opts_set, value); SET_OPTION_IF_UNSET (opts, opts_set, flag_profile_correction, value); - SET_OPTION_IF_UNSET (opts, opts_set, - param_early_inliner_max_iterations, 10); break; case OPT_fprofile_generate_:
reply other threads:[~2022-02-01 23:20 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220201232038.182E43858437@sourceware.org \ --to=erozen@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).