public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-7003] libstdc++: Fix link failure in _OutputIteratorConcept
@ 2022-02-02 17:37 Jonathan Wakely
0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2022-02-02 17:37 UTC (permalink / raw)
To: gcc-cvs, libstdc++-cvs
https://gcc.gnu.org/g:b229c5186093fa6603030ae83d5fe640ef7051a4
commit r12-7003-gb229c5186093fa6603030ae83d5fe640ef7051a4
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Jan 25 21:29:31 2022 +0000
libstdc++: Fix link failure in _OutputIteratorConcept
The C++98-style concept check for output iterators causes a link
failure on mingw-w64, because the __val() member function isn't defined.
Change it to use a function pointer instead. That pointer is never set
to anything meaningful, but it doesn't matter as the __constraints()
function only has to be instantiated, it's never called.
We could refactor all of these to use unevaluated contexts (e.g. sizeof
of __decltype) so that we only check the expressions are well-formed,
without any codegen at all. Any improvements to these are very low
priority though.
libstdc++-v3/ChangeLog:
* include/bits/boost_concept_check.h (_OutputIteratorConcept):
Change member function to data member of function pointer type.
Diff:
---
libstdc++-v3/include/bits/boost_concept_check.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libstdc++-v3/include/bits/boost_concept_check.h b/libstdc++-v3/include/bits/boost_concept_check.h
index 23dba067693..3d884eb440f 100644
--- a/libstdc++-v3/include/bits/boost_concept_check.h
+++ b/libstdc++-v3/include/bits/boost_concept_check.h
@@ -483,7 +483,9 @@ struct _Aux_require_same<_Tp,_Tp> { typedef _Tp _Type; };
*__i++ = __val(); // require postincrement and assignment
}
_Tp __i;
- _ValueT __val() const;
+ // Use a function pointer here so no definition of the function needed.
+ // Just need something that returns a _ValueT (which might be a reference).
+ _ValueT (*__val)();
};
template<typename _Tp>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-02-02 17:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-02 17:37 [gcc r12-7003] libstdc++: Fix link failure in _OutputIteratorConcept Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).