public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Sandiford <rsandifo@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-7245] vect: Fix early free Date: Tue, 15 Feb 2022 18:10:00 +0000 (GMT) [thread overview] Message-ID: <20220215181000.EF3F73858C83@sourceware.org> (raw) https://gcc.gnu.org/g:63a9328cb8c601377fe73e214b708c4ae0441847 commit r12-7245-g63a9328cb8c601377fe73e214b708c4ae0441847 Author: Richard Sandiford <richard.sandiford@arm.com> Date: Tue Feb 15 18:09:33 2022 +0000 vect: Fix early free When updating the target costs interface, I failed to move the free of the scalar costs beyond the new last use. gcc/ * tree-vect-slp.cc (vect_bb_vectorization_profitable_p): Fix use after free. Diff: --- gcc/tree-vect-slp.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index e2cc7218c2b..273543d37ea 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -5380,7 +5380,6 @@ vect_bb_vectorization_profitable_p (bb_vec_info bb_vinfo, unsigned dummy; finish_cost (scalar_target_cost_data, nullptr, &dummy, &scalar_cost, &dummy); - delete scalar_target_cost_data; /* Complete the target-specific vector cost calculation. */ class vector_costs *vect_target_cost_data = init_cost (bb_vinfo, false); @@ -5393,6 +5392,7 @@ vect_bb_vectorization_profitable_p (bb_vec_info bb_vinfo, && li_vector_costs[vi].first == vl); finish_cost (vect_target_cost_data, scalar_target_cost_data, &vec_prologue_cost, &vec_inside_cost, &vec_epilogue_cost); + delete scalar_target_cost_data; delete vect_target_cost_data; vec_outside_cost = vec_prologue_cost + vec_epilogue_cost;
reply other threads:[~2022-02-15 18:10 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220215181000.EF3F73858C83@sourceware.org \ --to=rsandifo@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).