public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: H.J. Lu <hjl@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-7429] Clear currently_expanding_gimple_stmt properly
Date: Tue,  1 Mar 2022 14:18:42 +0000 (GMT)	[thread overview]
Message-ID: <20220301141842.C13493858D20@sourceware.org> (raw)

https://gcc.gnu.org/g:88f91d8ccc8fec3a811975e3e4765b9a94d3f764

commit r12-7429-g88f91d8ccc8fec3a811975e3e4765b9a94d3f764
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Feb 28 15:18:04 2022 -0800

    Clear currently_expanding_gimple_stmt properly
    
    commit a5883ba0de68efad36db145e75c86394d8bd44ea
    Author: Michael Matz <matz@gcc.gnu.org>
    Date:   Tue Nov 24 15:37:32 2009 +0000
    
    introduced currently_expanding_gimple_stmt, which was set and cleared in
    expand_gimple_basic_block when expanding gimple statement to RTL.  But it
    isn't cleared when expand_gimple_basic_block returns inside the loop.
    
            PR middle-end/104721
            * cfgexpand.cc (expand_gimple_basic_block): Clear
            currently_expanding_gimple_stmt when returning inside the loop.

Diff:
---
 gcc/cfgexpand.cc | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gcc/cfgexpand.cc b/gcc/cfgexpand.cc
index d51af2e3084..87536ec7ccd 100644
--- a/gcc/cfgexpand.cc
+++ b/gcc/cfgexpand.cc
@@ -5927,7 +5927,10 @@ expand_gimple_basic_block (basic_block bb, bool disable_tail_calls)
 	{
 	  new_bb = expand_gimple_cond (bb, as_a <gcond *> (stmt));
 	  if (new_bb)
-	    return new_bb;
+	    {
+	      currently_expanding_gimple_stmt = NULL;
+	      return new_bb;
+	    }
 	}
       else if (is_gimple_debug (stmt))
 	{
@@ -6049,7 +6052,10 @@ expand_gimple_basic_block (basic_block bb, bool disable_tail_calls)
 		  if (can_fallthru)
 		    bb = new_bb;
 		  else
-		    return new_bb;
+		    {
+		      currently_expanding_gimple_stmt = NULL;
+		      return new_bb;
+		    }
 		}
 	    }
 	  else


                 reply	other threads:[~2022-03-01 14:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220301141842.C13493858D20@sourceware.org \
    --to=hjl@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).