From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 534DE385841C; Tue, 1 Mar 2022 14:25:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 534DE385841C MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-7432] tree-optimization/104716 - check if we can copy loop in loop distribution X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 8fba8a8c26a22fc5fbc17a99605e0226dc6fbf28 X-Git-Newrev: 54ef95cc4d1f3f2cde7c1f13250f889ffb81ca75 Message-Id: <20220301142550.534DE385841C@sourceware.org> Date: Tue, 1 Mar 2022 14:25:50 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 14:25:50 -0000 https://gcc.gnu.org/g:54ef95cc4d1f3f2cde7c1f13250f889ffb81ca75 commit r12-7432-g54ef95cc4d1f3f2cde7c1f13250f889ffb81ca75 Author: Richard Biener Date: Tue Mar 1 09:24:26 2022 +0100 tree-optimization/104716 - check if we can copy loop in loop distribution The following checks whether we can copy the loop before attempting to do so in loop distribution. In the testcase there's a computed goto and thus abnormal edges which we cannot redirect. 2022-03-01 Richard Biener PR tree-optimization/104716 * tree-loop-distribution.cc (find_seed_stmts_for_distribution): Check if we can copy the loop. * gfortran.dg/pr104716.f: New testcase. Diff: --- gcc/testsuite/gfortran.dg/pr104716.f | 31 +++++++++++++++++++++++++++++++ gcc/tree-loop-distribution.cc | 9 ++++++++- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/gfortran.dg/pr104716.f b/gcc/testsuite/gfortran.dg/pr104716.f new file mode 100644 index 00000000000..97f899a9201 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr104716.f @@ -0,0 +1,31 @@ +! { dg-do compile } +! { dg-options "-std=legacy -O2 -ftree-loop-distribution -fno-move-loop-stores -fno-tree-dominator-opts" } + + SUBROUTINE FOO() + + COMMON /WORK/ C2(2, 2) + + DIMENSION D11(2) + + EQUIVALENCE (D11(1), C2(1, 1)) + + DO 40 I = 1, 2 + DO 30 J = 1, 2 + ASSIGN 10 TO ILBL + IF (C2(J, I) .NE. 0.0) THEN + ASSIGN 20 TO ILBL + ENDIF + GO TO ILBL + 10 CONTINUE + 20 CONTINUE + C2(J, I) = C2(J, I) + 1 + 30 CONTINUE + 40 CONTINUE + + DO 50 I = 1, 2 + PRINT 90, I + 50 CONTINUE + + RETURN + 90 FORMAT(I5) + END diff --git a/gcc/tree-loop-distribution.cc b/gcc/tree-loop-distribution.cc index 8ee40d88816..db6e9096a86 100644 --- a/gcc/tree-loop-distribution.cc +++ b/gcc/tree-loop-distribution.cc @@ -3277,8 +3277,15 @@ find_seed_stmts_for_distribution (class loop *loop, vec *work_list) work_list->safe_push (stmt); } } + bool res = work_list->length () > 0; + if (res && !can_copy_bbs_p (bbs, loop->num_nodes)) + { + if (dump_file && (dump_flags & TDF_DETAILS)) + fprintf (dump_file, "cannot copy loop %d.\n", loop->num); + res = false; + } free (bbs); - return work_list->length () > 0; + return res; } /* A helper function for generate_{rawmemchr,strlen}_builtin functions in order