public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-7612] target/104762 - vectorization costs of CONSTRUCTORs Date: Fri, 11 Mar 2022 14:03:19 +0000 (GMT) [thread overview] Message-ID: <20220311140319.EA0313858D1E@sourceware.org> (raw) https://gcc.gnu.org/g:69619acd8d9b5856f5af6e5323d9c7c4ec9ad08f commit r12-7612-g69619acd8d9b5856f5af6e5323d9c7c4ec9ad08f Author: Richard Biener <rguenther@suse.de> Date: Fri Mar 11 11:51:13 2022 +0100 target/104762 - vectorization costs of CONSTRUCTORs After accounting for GPR -> XMM move cost for vec_construct the base cost needs adjustments to not double-cost those. This also lowers the cost when such move is not necessary. 2022-03-11 Richard Biener <rguenther@suse.de> PR target/104762 * config/i386/i386.cc (ix86_builtin_vectorization_cost): Do not cost the first lane of SSE pieces as inserts for vec_construct. Diff: --- gcc/config/i386/i386.cc | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index 4121f986221..23bedea92bd 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -22597,16 +22597,21 @@ ix86_builtin_vectorization_cost (enum vect_cost_for_stmt type_of_cost, case vec_construct: { - /* N element inserts into SSE vectors. */ - int cost = TYPE_VECTOR_SUBPARTS (vectype) * ix86_cost->sse_op; + int n = TYPE_VECTOR_SUBPARTS (vectype); + /* N - 1 element inserts into an SSE vector, the possible + GPR -> XMM move is accounted for in add_stmt_cost. */ + if (GET_MODE_BITSIZE (mode) <= 128) + return (n - 1) * ix86_cost->sse_op; /* One vinserti128 for combining two SSE vectors for AVX256. */ - if (GET_MODE_BITSIZE (mode) == 256) - cost += ix86_vec_cost (mode, ix86_cost->addss); + else if (GET_MODE_BITSIZE (mode) == 256) + return ((n - 2) * ix86_cost->sse_op + + ix86_vec_cost (mode, ix86_cost->addss)); /* One vinserti64x4 and two vinserti128 for combining SSE and AVX256 vectors to AVX512. */ else if (GET_MODE_BITSIZE (mode) == 512) - cost += 3 * ix86_vec_cost (mode, ix86_cost->addss); - return cost; + return ((n - 4) * ix86_cost->sse_op + + 3 * ix86_vec_cost (mode, ix86_cost->addss)); + gcc_unreachable (); } default:
reply other threads:[~2022-03-11 14:03 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220311140319.EA0313858D1E@sourceware.org \ --to=rguenth@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).