public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-7654] i386: Use no-mmx, no-sse for LIBGCC2_UNWIND_ATTRIBUTE [PR104890]
Date: Tue, 15 Mar 2022 09:24:50 +0000 (GMT)	[thread overview]
Message-ID: <20220315092450.56F7A3858021@sourceware.org> (raw)

https://gcc.gnu.org/g:da24fce323eaf088239e0f900dd23f6b05d552c1

commit r12-7654-gda24fce323eaf088239e0f900dd23f6b05d552c1
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Mar 15 10:24:22 2022 +0100

    i386: Use no-mmx,no-sse for LIBGCC2_UNWIND_ATTRIBUTE [PR104890]
    
    Regardless of the outcome of the general-regs-only stuff in x86gprintrin.h,
    apparently general-regs-only is much bigger hammer than no-sse, and e.g.
    using 387 instructions in the unwinder isn't a big deal, it never needs
    to realign the stack because of it.
    
    So, the following patch uses no-sse (and adds no-mmx to it, even when not
    strictly needed).
    
    2022-03-15  Jakub Jelinek  <jakub@redhat.com>
    
            PR target/104890
            * config/i386/i386.h (LIBGCC2_UNWIND_ATTRIBUTE): Use no-mmx,no-sse
            instead of general-regs-only.

Diff:
---
 gcc/config/i386/i386.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h
index 0d28e57f8f2..37b523cea4f 100644
--- a/gcc/config/i386/i386.h
+++ b/gcc/config/i386/i386.h
@@ -2848,10 +2848,10 @@ extern enum attr_cpu ix86_schedule;
 #define NUM_X86_64_MS_CLOBBERED_REGS 12
 #endif
 
-/* __builtin_eh_return can't handle stack realignment, so restrict to
-   general regs in 32-bit libgcc functions that call it.  */
+/* __builtin_eh_return can't handle stack realignment, so disable MMX/SSE
+   in 32-bit libgcc functions that call it.  */
 #ifndef __x86_64__
-#define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("general-regs-only")))
+#define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("no-mmx,no-sse")))
 #endif
 
 /*


                 reply	other threads:[~2022-03-15  9:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220315092450.56F7A3858021@sourceware.org \
    --to=jakub@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).