public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Meissner <meissner@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/meissner/heads/work082)] Make addti3/subti3 be define_insn_and_split, instead of define_expand
Date: Wed, 23 Mar 2022 00:56:11 +0000 (GMT)	[thread overview]
Message-ID: <20220323005611.925E73858401@sourceware.org> (raw)

https://gcc.gnu.org/g:606232ceddf0d55c005ba67029c6cd26a3e83fc8

commit 606232ceddf0d55c005ba67029c6cd26a3e83fc8
Author: Michael Meissner <meissner@linux.ibm.com>
Date:   Tue Mar 22 20:55:55 2022 -0400

    Make addti3/subti3 be define_insn_and_split, instead of define_expand
    
    This patch makes addti3 and subti3 be define_insn_and_split instead of
    define_expand.  This patch will be a building block to support in a future
    patch PR target/103109 which wants to optimize 128-bit some integer
    multiply-add combinations to use the power9 maddld, maddhd, maddhdu
    instructions.  In order to support recognizing the multiply and add
    combination, we need to keep the addti3 and subti3 as complete insns
    through the combiner phase.
    
    2022-03-22   Michael Meissner  <meissner@linux.ibm.com>
    
    gcc/
            * config/rs6000/rs6000.md (addti3): Don't immediate expand the
            insn, delay expansion until the split passes.
            (subti3): Likewise.

Diff:
---
 gcc/config/rs6000/rs6000.md | 41 +++++++++++++++++++++++++++++------------
 1 file changed, 29 insertions(+), 12 deletions(-)

diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
index fdfbc6566a5..df8a750d945 100644
--- a/gcc/config/rs6000/rs6000.md
+++ b/gcc/config/rs6000/rs6000.md
@@ -7029,12 +7029,19 @@
 ;; allocator from allocating registers that overlap with the inputs
 ;; (for example, having an input in 7,8 and an output in 6,7).  We
 ;; also allow for the output being the same as one of the inputs.
-
-(define_expand "addti3"
-  [(set (match_operand:TI 0 "gpc_reg_operand")
-	(plus:TI (match_operand:TI 1 "gpc_reg_operand")
-		 (match_operand:TI 2 "reg_or_short_operand")))]
+;;
+;; Addti3/subti3 are define_insn_and_splits instead of define_expand, to allow
+;; for combine to make things like multiply and add with extend operations.
+
+(define_insn_and_split "addti3"
+  [(set (match_operand:TI 0 "gpc_reg_operand"               "=&r,r,r")
+	(plus:TI (match_operand:TI 1 "gpc_reg_operand"       "r, 0,r")
+		 (match_operand:TI 2 "reg_or_short_operand"  "rI,r,0")))
+   (clobber (reg:DI CA_REGNO))]
   "TARGET_64BIT"
+  "#"
+  "&& 1"
+  [(pc)]
 {
   rtx lo0 = gen_lowpart (DImode, operands[0]);
   rtx lo1 = gen_lowpart (DImode, operands[1]);
@@ -7051,13 +7058,20 @@
   emit_insn (gen_adddi3_carry (lo0, lo1, lo2));
   emit_insn (gen_adddi3_carry_in (hi0, hi1, hi2));
   DONE;
-})
-
-(define_expand "subti3"
-  [(set (match_operand:TI 0 "gpc_reg_operand")
-	(minus:TI (match_operand:TI 1 "reg_or_short_operand")
-		  (match_operand:TI 2 "gpc_reg_operand")))]
+}
+  [(set_attr "length" "8")
+   (set_attr "type"   "add")
+   (set_attr "size"   "128")])
+
+(define_insn_and_split "subti3"
+  [(set (match_operand:TI 0 "gpc_reg_operand"                "=&r,r,r")
+	(minus:TI (match_operand:TI 1 "reg_or_short_operand" "rI,0,r")
+		  (match_operand:TI 2 "gpc_reg_operand"      "r, r,0")))
+   (clobber (reg:DI CA_REGNO))]
   "TARGET_64BIT"
+  "#"
+  "&& 1"
+  [(pc)]
 {
   rtx lo0 = gen_lowpart (DImode, operands[0]);
   rtx lo1 = gen_lowpart (DImode, operands[1]);
@@ -7074,7 +7088,10 @@
   emit_insn (gen_subfdi3_carry (lo0, lo2, lo1));
   emit_insn (gen_subfdi3_carry_in (hi0, hi2, hi1));
   DONE;
-})
+}
+  [(set_attr "length" "8")
+   (set_attr "type"   "add")
+   (set_attr "size"   "128")])
 \f
 ;; 128-bit logical operations expanders


             reply	other threads:[~2022-03-23  0:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23  0:56 Michael Meissner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-03-22 17:41 Michael Meissner
2022-03-19  1:24 Michael Meissner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220323005611.925E73858401@sourceware.org \
    --to=meissner@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).