From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 2A10D3858427; Wed, 23 Mar 2022 09:30:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A10D3858427 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-7777] testsuite: Fix up sse2-v1ti-shift-3.c test [PR102986] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/master X-Git-Oldrev: 1002a7ace111d746249fdea71af9b8e039cea0eb X-Git-Newrev: 4a9e92164a547afcf8cd3fc593c7660238ad2d59 Message-Id: <20220323093008.2A10D3858427@sourceware.org> Date: Wed, 23 Mar 2022 09:30:08 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2022 09:30:08 -0000 https://gcc.gnu.org/g:4a9e92164a547afcf8cd3fc593c7660238ad2d59 commit r12-7777-g4a9e92164a547afcf8cd3fc593c7660238ad2d59 Author: Jakub Jelinek Date: Wed Mar 23 10:29:37 2022 +0100 testsuite: Fix up sse2-v1ti-shift-3.c test [PR102986] This test is dg-do run and invokes UB when these rotate functions are called with 0 as second argument. There are some other tests that do this but they are dg-do compile only and not even call those functions at all, so it IMHO doesn't matter that they are only well defined for [1,127] and not [0,127]. The following patch fixes it, we pattern recognize both forms as rotates and we emit identical assembly. 2022-03-23 Jakub Jelinek PR target/102986 * gcc.target/i386/sse2-v1ti-shift-3.c (rotr_v1ti, rotl_v1ti, rotr_ti, rotl_ti): Use -i&127 instead of 128-i to avoid UB on i == 0. Diff: --- gcc/testsuite/gcc.target/i386/sse2-v1ti-shift-3.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/testsuite/gcc.target/i386/sse2-v1ti-shift-3.c b/gcc/testsuite/gcc.target/i386/sse2-v1ti-shift-3.c index 8d5c1227e3c..b4739d30da9 100644 --- a/gcc/testsuite/gcc.target/i386/sse2-v1ti-shift-3.c +++ b/gcc/testsuite/gcc.target/i386/sse2-v1ti-shift-3.c @@ -14,14 +14,14 @@ typedef __int128 ti; uv1ti ashl_v1ti(uv1ti x, unsigned int i) { return x << i; } uv1ti lshr_v1ti(uv1ti x, unsigned int i) { return x >> i; } sv1ti ashr_v1ti(sv1ti x, unsigned int i) { return x >> i; } -uv1ti rotr_v1ti(uv1ti x, unsigned int i) { return (x >> i) | (x << (128-i)); } -uv1ti rotl_v1ti(uv1ti x, unsigned int i) { return (x << i) | (x >> (128-i)); } +uv1ti rotr_v1ti(uv1ti x, unsigned int i) { return (x >> i) | (x << (-i&127)); } +uv1ti rotl_v1ti(uv1ti x, unsigned int i) { return (x << i) | (x >> (-i&127)); } uti ashl_ti(uti x, unsigned int i) { return x << i; } uti lshr_ti(uti x, unsigned int i) { return x >> i; } sti ashr_ti(sti x, unsigned int i) { return x >> i; } -uti rotr_ti(uti x, unsigned int i) { return (x >> i) | (x << (128-i)); } -uti rotl_ti(uti x, unsigned int i) { return (x << i) | (x >> (128-i)); } +uti rotr_ti(uti x, unsigned int i) { return (x >> i) | (x << (-i&127)); } +uti rotl_ti(uti x, unsigned int i) { return (x << i) | (x >> (-i&127)); } void test(ti x) {