public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-7786] target/102125 - alternative memcpy folding improvement Date: Wed, 23 Mar 2022 14:57:55 +0000 (GMT) [thread overview] Message-ID: <20220323145755.2F95F3857C49@sourceware.org> (raw) https://gcc.gnu.org/g:d9792f8d227cdd409c2b082ef0685b47ccfaa334 commit r12-7786-gd9792f8d227cdd409c2b082ef0685b47ccfaa334 Author: Richard Biener <rguenther@suse.de> Date: Wed Mar 23 14:53:49 2022 +0100 target/102125 - alternative memcpy folding improvement The following extends the heuristical memcpy folding path with the ability to use misaligned accesses on strict-alignment targets just like the size-based path does. That avoids regressing the following testcase on arm uint64_t bar64(const uint8_t *rData1) { uint64_t buffer; memcpy(&buffer, rData1, sizeof(buffer)); return buffer; } when r12-3482-g5f6a6c91d7c592 is reverted. 2022-03-23 Richard Biener <rguenther@suse.de> PR target/102125 * gimple-fold.cc (gimple_fold_builtin_memory_op): Allow the use of movmisalign when either the source or destination decl is properly aligned. Diff: --- gcc/gimple-fold.cc | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/gcc/gimple-fold.cc b/gcc/gimple-fold.cc index c9179abb27e..5eff7d68ac1 100644 --- a/gcc/gimple-fold.cc +++ b/gcc/gimple-fold.cc @@ -1254,7 +1254,11 @@ gimple_fold_builtin_memory_op (gimple_stmt_iterator *gsi, srcvar = fold_build2 (MEM_REF, desttype, src, off0); else { - if (STRICT_ALIGNMENT) + enum machine_mode mode = TYPE_MODE (desttype); + if ((mode == BLKmode && STRICT_ALIGNMENT) + || (targetm.slow_unaligned_access (mode, src_align) + && (optab_handler (movmisalign_optab, mode) + == CODE_FOR_nothing))) return false; srctype = build_aligned_type (TYPE_MAIN_VARIANT (desttype), src_align); @@ -1267,7 +1271,11 @@ gimple_fold_builtin_memory_op (gimple_stmt_iterator *gsi, destvar = fold_build2 (MEM_REF, srctype, dest, off0); else { - if (STRICT_ALIGNMENT) + enum machine_mode mode = TYPE_MODE (srctype); + if ((mode == BLKmode && STRICT_ALIGNMENT) + || (targetm.slow_unaligned_access (mode, dest_align) + && (optab_handler (movmisalign_optab, mode) + == CODE_FOR_nothing))) return false; desttype = build_aligned_type (TYPE_MAIN_VARIANT (srctype), dest_align);
reply other threads:[~2022-03-23 14:57 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220323145755.2F95F3857C49@sourceware.org \ --to=rguenth@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).