public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-7834] Remove mysterious '-# Defining these options here in addition to common.opt is necessary' command-li
Date: Sat, 26 Mar 2022 20:33:19 +0000 (GMT)	[thread overview]
Message-ID: <20220326203319.AB3333858D28@sourceware.org> (raw)

https://gcc.gnu.org/g:43911ddd18b97d8ebd17d2959f36efa539d359b7

commit r12-7834-g43911ddd18b97d8ebd17d2959f36efa539d359b7
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Thu Mar 24 22:34:30 2022 +0100

    Remove mysterious '-# Defining these options here in addition to common.opt is necessary' command-line option
    
    Before:
    
        $ [...]/gcc '-# Defining these options here in addition to common.opt is necessary' -S -x c /dev/null && echo MYSTERIOUS
        MYSTERIOUS
    
    After:
    
        $ [...]/gcc '-# Defining these options here in addition to common.opt is necessary' -S -x c /dev/null && echo MYSTERIOUS
        gcc: error: unrecognized command-line option ‘-# Defining these options here in addition to common.opt is necessary’
    
    This commit changes:
    
        --- [...]/build-gcc/gcc/optionlist  2022-03-24 22:12:07.936746648 +0100
        +++ [...]/build-gcc/gcc/optionlist  2022-03-24 22:30:06.976737341 +0100
        @@ -1,4 +1,3 @@
        -# Defining these options here in addition to common.opt is necessary\x1c# in order for the default -Wall setting of -Wuse-after-free=2 to take\x1c# effect.
         ###\x1cDriver
         -all-warnings\x1cAda AdaWhy AdaSCIL Alias(Wall)
         -all-warnings\x1cC ObjC C++ ObjC++ Warning Alias(Wall)
        [...]
    
        --- [...]/build-gcc/gcc/options.cc  2022-03-24 22:12:09.548727738 +0100
        +++ [...]/build-gcc/gcc/options.cc  2022-03-24 22:30:08.904727249 +0100
        @@ -3222,15 +3222,6 @@
         const struct cl_option cl_options[] =
         {
          /* [0] = */ {
        -    "-# Defining these options here in addition to common.opt is necessary",
        -    "# effect.",
        -    NULL,
        -    NULL,
        -    NULL, NULL, N_OPTS, N_OPTS, 68, /* .neg_idx = */ -1,
        -    0,
        -    0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
        -    (unsigned short) -1, 0, CLVC_INTEGER, 0, -1, -1 },
        - /* [1] = */ {
             "-###",
             NULL,
             NULL,
        [...]
    
    ..., and re-numbers all following options.
    
        --- [...]/build-gcc/gcc/options.h   2022-03-21 23:24:25.894226828 +0100
        +++ [...]/build-gcc/gcc/options.h   2022-03-24 22:30:07.288735708 +0100
        @@ -9753,2118 +9753,2117 @@
    
         enum opt_code
         {
        -  OPT___Defining_these_options_here_in_addition_to_common_opt_is_necessary = 0,/* -# Defining these options here in addition to common.opt is necessary */
        [...]
    
    ..., and likewise re-numbers all following options.
    
    Clean-up for commit 671a283636de75f7ed638ee6b01ed2d44361b8b6
    "Add -Wuse-after-free [PR80532]".
    
            gcc/c-family/
            * c.opt: Properly quote comment.

Diff:
---
 gcc/c-family/c.opt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt
index 9a4828ebe37..790d47caf0a 100644
--- a/gcc/c-family/c.opt
+++ b/gcc/c-family/c.opt
@@ -1377,9 +1377,9 @@ Wunused-const-variable=
 C ObjC C++ ObjC++ Joined RejectNegative UInteger Var(warn_unused_const_variable) Warning LangEnabledBy(C ObjC,Wunused-variable, 1, 0) IntegerRange(0, 2)
 Warn when a const variable is unused.
 
-# Defining these options here in addition to common.opt is necessary
-# in order for the default -Wall setting of -Wuse-after-free=2 to take
-# effect.
+; Defining these options here in addition to common.opt is necessary
+; in order for the default -Wall setting of -Wuse-after-free=2 to take
+; effect.
 
 Wuse-after-free
 LangEnabledBy(C ObjC C++ LTO ObjC++)


                 reply	other threads:[~2022-03-26 20:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220326203319.AB3333858D28@sourceware.org \
    --to=tschwinge@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).