From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2122) id 92B863858C2C; Mon, 28 Mar 2022 13:37:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 92B863858C2C MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jason Merrill To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-7854] c++: visibility of local extern [PR103291] X-Act-Checkin: gcc X-Git-Author: Jason Merrill X-Git-Refname: refs/heads/master X-Git-Oldrev: b854ce130ebbfdf2f882ef08538746030513b44b X-Git-Newrev: 8796eb27e24bd3340ebd393e96a94b91d09407e9 Message-Id: <20220328133738.92B863858C2C@sourceware.org> Date: Mon, 28 Mar 2022 13:37:38 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2022 13:37:38 -0000 https://gcc.gnu.org/g:8796eb27e24bd3340ebd393e96a94b91d09407e9 commit r12-7854-g8796eb27e24bd3340ebd393e96a94b91d09407e9 Author: Jason Merrill Date: Sun Mar 27 09:44:59 2022 -0400 c++: visibility of local extern [PR103291] When setting up the hidden namespace-scope decl for a local extern, we also need to set its visibility. PR c++/103291 gcc/cp/ChangeLog: * name-lookup.cc (push_local_extern_decl_alias): Call determine_visibility. gcc/testsuite/ChangeLog: * g++.dg/ext/visibility/visibility-local-extern1.C: New test. Diff: --- gcc/cp/name-lookup.cc | 3 +++ gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/gcc/cp/name-lookup.cc b/gcc/cp/name-lookup.cc index 3c7b626350f..c833b84ca8a 100644 --- a/gcc/cp/name-lookup.cc +++ b/gcc/cp/name-lookup.cc @@ -3476,6 +3476,9 @@ push_local_extern_decl_alias (tree decl) && CP_DECL_THREAD_LOCAL_P (decl) && alias != error_mark_node) set_decl_tls_model (alias, DECL_TLS_MODEL (decl)); + + /* Adjust visibility. */ + determine_visibility (alias); } } diff --git a/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C new file mode 100644 index 00000000000..40c20199d0c --- /dev/null +++ b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C @@ -0,0 +1,10 @@ +// PR c++/103291 +// { dg-additional-options -fpic } +// { dg-final { scan-assembler-not "@GOTPCREL" } } + +#pragma GCC visibility push(hidden) + +int hidden_fetch(void) { + extern const int hidden_global; + return hidden_global; +}