From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1005) id C7F9A3858C52; Tue, 29 Mar 2022 03:06:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C7F9A3858C52 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Michael Meissner To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/meissner/heads/work084)] Update ChangeLog.meissner. X-Act-Checkin: gcc X-Git-Author: Michael Meissner X-Git-Refname: refs/users/meissner/heads/work084 X-Git-Oldrev: b7c26f4f6f4a8e953278f4a37dd51641ab7125fe X-Git-Newrev: 955759242cc723ffecb0b47202e07335c9e21032 Message-Id: <20220329030619.C7F9A3858C52@sourceware.org> Date: Tue, 29 Mar 2022 03:06:19 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2022 03:06:19 -0000 https://gcc.gnu.org/g:955759242cc723ffecb0b47202e07335c9e21032 commit 955759242cc723ffecb0b47202e07335c9e21032 Author: Michael Meissner Date: Mon Mar 28 23:06:00 2022 -0400 Update ChangeLog.meissner. 2022-03-28 Michael Meissner gcc/ * ChangeLog.meissner: Update. Diff: --- gcc/ChangeLog.meissner | 79 ++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 77 insertions(+), 2 deletions(-) diff --git a/gcc/ChangeLog.meissner b/gcc/ChangeLog.meissner index 5293370cb48..cc395f2f000 100644 --- a/gcc/ChangeLog.meissner +++ b/gcc/ChangeLog.meissner @@ -1,12 +1,87 @@ ==================== Work084, patch #1: -Update ChangeLog.meissner. + +Optimize vec_splats of constant vec_extract for V2DI/V2DF, PR target 99293. + +In PR target/99293, it was pointed out that doing: + + vector long long dest0, dest1, src; + /* ... */ + dest0 = vec_splats (vec_extract (src, 0)); + dest1 = vec_splats (vec_extract (src, 1)); + +would generate slower code. + +It generates the following code on power8: + + ;; vec_splats (vec_extract (src, 0)) + xxpermdi 0,34,34,3 + xxpermdi 34,0,0,0 + + ;; vec_splats (vec_extract (src, 1)) + xxlor 0,34,34 + xxpermdi 34,0,0,0 + +However on power9 and power10 it generates: + + ;; vec_splats (vec_extract (src, 0)) + mfvsld 3,34 + mtvsrdd 34,9,9 + + ;; vec_splats (vec_extract (src, 1)) + mfvsrd 9,34 + mtvsrdd 34,9,9 + +This is due to the power9 having the mfvsrld instruction which can extract +either 64-bit element into a GPR. While there are alternatives for both +vector registers and GPR registers, the register allocator prefers to put +DImode into GPR registers. + +However in this case, it is better to have a single combiner pattern that +can generate a single xxpermdi, instead of doing 2 insnsns (the extract +and then the concat). This is particularly true if the two operations are +move from vector register and move to vector register. As Segher pointed +out in a previous version of the patch, the combiner already tries doing +creating a (vec_duplicate (vec_select ...)) pattern, but we didn't provide +one. + +I rewrote the existing pattern vsx_xxspltd_ to have a VEC_DUPLCIATE +so that the case would match for the PR instead of using UNSPEC. + +I have built Spec 2017 with this patch installed, and the cam4_r benchmark +is the only benchmark that generated different code. On a power9, I did +not notice any significant changes in the runtime of cam4_r. + +I have built bootstrap versions on the following systems. There were no +regressions in the runs: + + Power9 little endian, --with-cpu=power9 + Power10 little endian, --with-cpu=power10 + Power8 big endian, --with-cpu=power8 (both 32-bit & 64-bit tests) + +Can I install this into the trunk? After a burn-in period, can I backport +and install this into GCC 11 and GCC 10 branches? + +2022-03-28 Michael Meissner + +gcc/ + PR target/99293 + * config/rs6000/rs6000-p8swap.cc (rtx_is_swappable_p): Remove + UNSPEC_VSX_XXSPLTD case. + * config/rs6000/vsx.md (UNSPEC_VSX_XXSPLTD): Delete. + (vsx_xxspltd_): Rewrite to use VEC_DUPLICATE. + +gcc/testsuite: + PR target/99293 + * gcc.target/powerpc/builtins-1.c: Update insn count. + * gcc.target/powerpc/pr99293.c: New test. 2022-03-28 Michael Meissner gcc/ * ChangeLog.meissner: Update. +==================== Work084, branch start + 2022-03-28 Michael Meissner Clone branch -