public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r11-9723] cfgrtl: Fix up -g vs. -g0 code generation -flto differences in fixup_reorder_chain [PR104589]
Date: Tue, 29 Mar 2022 05:53:42 +0000 (GMT)	[thread overview]
Message-ID: <20220329055342.7DEBD385E83D@sourceware.org> (raw)

https://gcc.gnu.org/g:7737259ceaa490a1cc75415efa00f3631a7e17df

commit r11-9723-g7737259ceaa490a1cc75415efa00f3631a7e17df
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Mar 2 10:48:14 2022 +0100

    cfgrtl: Fix up -g vs. -g0 code generation -flto differences in fixup_reorder_chain [PR104589]
    
    This is similar to PR104237 and similarly to that, no testcase included
    for the testsuite, as we don't have a framework to compile/link with
    -g -flto and -g0 -flto and compare -fdump-final-insns= results from
    the lto1 compilations.
    
    With -flto, whether two location_t compare equal or not and just
    express the same location is a lottery.
    
    2022-03-02  Jakub Jelinek  <jakub@redhat.com>
    
            PR rtl-optimization/104589
            * cfgrtl.c (fixup_reorder_chain): Use loc_equal instead of direct
            INSN_LOCATION comparison with goto_locus.
    
    (cherry picked from commit 2e1b00367abaf8b6dbb47fd8518d9ac69c326a06)

Diff:
---
 gcc/cfgrtl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c
index 418b957e050..8fd128b471c 100644
--- a/gcc/cfgrtl.c
+++ b/gcc/cfgrtl.c
@@ -4120,7 +4120,7 @@ fixup_reorder_chain (void)
 		     && (!NONDEBUG_INSN_P (insn) || !INSN_HAS_LOCATION (insn)))
 		insn = PREV_INSN (insn);
 	      if (insn != end
-		  && INSN_LOCATION (insn) == e->goto_locus)
+		  && loc_equal (INSN_LOCATION (insn), e->goto_locus))
 		continue;
 	      if (simplejump_p (BB_END (e->src))
 		  && !INSN_HAS_LOCATION (BB_END (e->src)))
@@ -4142,7 +4142,7 @@ fixup_reorder_chain (void)
 		  while (insn != end && !NONDEBUG_INSN_P (insn))
 		    insn = NEXT_INSN (insn);
 		  if (insn != end && INSN_HAS_LOCATION (insn)
-		      && INSN_LOCATION (insn) == e->goto_locus)
+		      && loc_equal (INSN_LOCATION (insn), e->goto_locus))
 		    continue;
 		}
 	      nb = split_edge (e);


                 reply	other threads:[~2022-03-29  5:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220329055342.7DEBD385E83D@sourceware.org \
    --to=jakub@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).