public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-8027] sh: Fix up __attribute__((optimize ("Os"))) handling on SH [PR105069]
@ 2022-04-06 15:42 Jakub Jelinek
  0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2022-04-06 15:42 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:6283d5ad4779d3e5b7b2a93e76de03264a7c7cc6

commit r12-8027-g6283d5ad4779d3e5b7b2a93e76de03264a7c7cc6
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Apr 6 17:36:54 2022 +0200

    sh: Fix up __attribute__((optimize ("Os"))) handling on SH [PR105069]
    
    As mentioned in the PR, various tests on sh-elf ICE like:
    make check-gcc RUNTESTFLAGS="compile.exp='pr104327.c pr58332.c pr81360.c pr84425.c'"
    FAIL: gcc.c-torture/compile/pr104327.c   -O0  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr104327.c   -O0  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr104327.c   -O1  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr104327.c   -O1  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr104327.c   -O2  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr104327.c   -O2  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr104327.c   -O3 -g  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr104327.c   -O3 -g  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr104327.c   -Os  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr58332.c   -O0  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr58332.c   -O1  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr58332.c   -O1  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr58332.c   -O2  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr58332.c   -O2  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr58332.c   -O3 -g  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr58332.c   -O3 -g  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr58332.c   -Os  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr58332.c   -Os  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr81360.c   -O0  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr81360.c   -O1  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr81360.c   -O1  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr81360.c   -O2  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr81360.c   -O2  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr81360.c   -O3 -g  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr81360.c   -O3 -g  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr81360.c   -Os  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr81360.c   -Os  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr84425.c   -O0  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr84425.c   -O1  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr84425.c   -O1  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr84425.c   -O2  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr84425.c   -O2  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr84425.c   -O3 -g  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr84425.c   -O3 -g  (test for excess errors)
    FAIL: gcc.c-torture/compile/pr84425.c   -Os  (internal compiler error: 'global_options' are modified in local context)
    FAIL: gcc.c-torture/compile/pr84425.c   -Os  (test for excess errors)
    With the following patch, none of those tests ICE anymore, though
    pr104327.c still FAILs with:
    Excess errors:
    /usr/src/gcc/gcc/testsuite/gcc.c-torture/compile/pr104327.c:6:1: error: inlining failed in call to 'always_inline' 'bar': target specific option mismatch
    I think that would be fixable by overriding TARGET_CAN_INLINE_P
    hook and allowing at least for always_inline changes in sh_div_str.
    
    2022-04-06  Jakub Jelinek  <jakub@redhat.com>
    
            PR target/105069
            * config/sh/sh.opt (mdiv=): Add Save.

Diff:
---
 gcc/config/sh/sh.opt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/sh/sh.opt b/gcc/config/sh/sh.opt
index 8618e78c1d6..f494ab84d4a 100644
--- a/gcc/config/sh/sh.opt
+++ b/gcc/config/sh/sh.opt
@@ -207,7 +207,7 @@ Target RejectNegative Mask(ALIGN_DOUBLE)
 Align doubles at 64-bit boundaries.
 
 mdiv=
-Target RejectNegative Joined Var(sh_div_str) Init("")
+Target Save RejectNegative Joined Var(sh_div_str) Init("")
 Division strategy, one of: call-div1, call-fp, call-table.
 
 mdivsi3_libfunc=


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-04-06 15:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-06 15:42 [gcc r12-8027] sh: Fix up __attribute__((optimize ("Os"))) handling on SH [PR105069] Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).