From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 71D453857811; Wed, 13 Apr 2022 04:28:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71D453857811 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r11-9847] c-family: Initialize ridpointers for __int128 etc. [PR105186] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/releases/gcc-11 X-Git-Oldrev: b28307530ecb4d6aea2328fb3e670068e3275868 X-Git-Newrev: 473f2b099bdb3e72591b37f42e566086792f453d Message-Id: <20220413042821.71D453857811@sourceware.org> Date: Wed, 13 Apr 2022 04:28:21 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 04:28:21 -0000 https://gcc.gnu.org/g:473f2b099bdb3e72591b37f42e566086792f453d commit r11-9847-g473f2b099bdb3e72591b37f42e566086792f453d Author: Jakub Jelinek Date: Mon Apr 11 10:41:07 2022 +0200 c-family: Initialize ridpointers for __int128 etc. [PR105186] The following testcase ICEs with C++ and is incorrectly rejected with C. The reason is that both FEs use ridpointers identifiers for CPP_KEYWORD and value or u.value for CPP_NAME e.g. when parsing attributes or OpenMP directives etc., like: /* Save away the identifier that indicates which attribute this is. */ identifier = (token->type == CPP_KEYWORD) /* For keywords, use the canonical spelling, not the parsed identifier. */ ? ridpointers[(int) token->keyword] : id_token->u.value; identifier = canonicalize_attr_name (identifier); I've tried to change those to use ridpointers only if non-NULL and otherwise use the value/u.value even for CPP_KEYWORDS, but that was a large 10 hunks patch. The following patch instead just initializes ridpointers for the __intNN keywords. It can't be done earlier before we record_builtin_type as there are 2 different spellings and if we initialize those ridpointers early, the second record_builtin_type fails miserably. 2022-04-11 Jakub Jelinek PR c++/105186 * c-common.c (c_common_nodes_and_builtins): After registering __int%d and __int%d__ builtin types, initialize corresponding ridpointers entry. * c-c++-common/pr105186.c: New test. (cherry picked from commit 083e8e66d2e90992fa83a53bfc3553dfa91abda1) Diff: --- gcc/c-family/c-common.c | 2 ++ gcc/testsuite/c-c++-common/pr105186.c | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c index a133c9efdb1..7b8f49d78dc 100644 --- a/gcc/c-family/c-common.c +++ b/gcc/c-family/c-common.c @@ -4070,6 +4070,8 @@ c_common_nodes_and_builtins (void) sprintf (name, "__int%d__", int_n_data[i].bitsize); record_builtin_type ((enum rid)(RID_FIRST_INT_N + i), name, int_n_trees[i].signed_type); + ridpointers[RID_FIRST_INT_N + i] + = DECL_NAME (TYPE_NAME (int_n_trees[i].signed_type)); sprintf (name, "__int%d unsigned", int_n_data[i].bitsize); record_builtin_type (RID_MAX, name, int_n_trees[i].unsigned_type); diff --git a/gcc/testsuite/c-c++-common/pr105186.c b/gcc/testsuite/c-c++-common/pr105186.c new file mode 100644 index 00000000000..ea687eacc4c --- /dev/null +++ b/gcc/testsuite/c-c++-common/pr105186.c @@ -0,0 +1,5 @@ +/* PR c++/105186 */ +/* { dg-do compile } */ + +__attribute__((__int128)) int i; /* { dg-warning "'__int128' attribute directive ignored" } */ +__attribute__((__int128__)) int j; /* { dg-warning "'__int128' attribute directive ignored" } */