public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Iain D Sandoe <iains@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r12-8166] libgccjit: Fix a bootstrap break for some targets.
Date: Thu, 14 Apr 2022 19:16:07 +0000 (GMT)	[thread overview]
Message-ID: <20220414191607.16EFB3858C53@sourceware.org> (raw)

https://gcc.gnu.org/g:82536fbb8a7d150b829650378e0ba07dad5c8fb8

commit r12-8166-g82536fbb8a7d150b829650378e0ba07dad5c8fb8
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Thu Apr 14 20:08:14 2022 +0100

    libgccjit: Fix a bootstrap break for some targets.
    
    Some targets use 'long long unsigned int' for unsigned HW int, and this
    leads to a Werror=format= fail for two print cases in jit-playback.cc
    introduced in r12-8117-g30f7c83e9cfe (Add support for bitcasts [PR104071])
    
    As discussed on IRC, casting to (long) seems entirely reasonable for the
    values (since they are type sizes).
    
    tested that this fixes bootstrap on x86_64-darwin19 and running check-jit.
    
    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
    
    gcc/jit/ChangeLog:
    
            * jit-playback.cc (new_bitcast): Cast values returned by tree_to_uhwi
            to 'long' to match the print format.

Diff:
---
 gcc/jit/jit-playback.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/jit/jit-playback.cc b/gcc/jit/jit-playback.cc
index b1e72fbcf8a..6be6bdf8dea 100644
--- a/gcc/jit/jit-playback.cc
+++ b/gcc/jit/jit-playback.cc
@@ -1440,10 +1440,10 @@ new_bitcast (location *loc,
     active_playback_ctxt->add_error (loc,
       "bitcast with types of different sizes");
     fprintf (stderr, "input expression (size: %ld):\n",
-      tree_to_uhwi (expr_size));
+      (long) tree_to_uhwi (expr_size));
     debug_tree (t_expr);
     fprintf (stderr, "requested type (size: %ld):\n",
-      tree_to_uhwi (type_size));
+      (long) tree_to_uhwi (type_size));
     debug_tree (t_dst_type);
   }
   tree t_bitcast = build1 (VIEW_CONVERT_EXPR, t_dst_type, t_expr);


                 reply	other threads:[~2022-04-14 19:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220414191607.16EFB3858C53@sourceware.org \
    --to=iains@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).