From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2209) id 0C71F385803E; Thu, 14 Apr 2022 22:43:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C71F385803E MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: David Malcolm To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-8169] analyzer: fix escaping of pointer arithmetic [PR105264] X-Act-Checkin: gcc X-Git-Author: David Malcolm X-Git-Refname: refs/heads/master X-Git-Oldrev: af27d545dc6132dcd67d1ee854372ea9cfd2a225 X-Git-Newrev: a358e4b60815b41e27f3508014ceb592f86b9b45 Message-Id: <20220414224343.0C71F385803E@sourceware.org> Date: Thu, 14 Apr 2022 22:43:43 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 22:43:43 -0000 https://gcc.gnu.org/g:a358e4b60815b41e27f3508014ceb592f86b9b45 commit r12-8169-ga358e4b60815b41e27f3508014ceb592f86b9b45 Author: David Malcolm Date: Thu Apr 14 09:52:00 2022 -0400 analyzer: fix escaping of pointer arithmetic [PR105264] PR analyzer/105264 reports that the analyzer can fail to treat (PTR + IDX) and PTR[IDX] as referring to the same memory under some situations. There are various ways in which this can happen when IDX is a symbolic value, due to having several ways in which such memory regions can be referred to symbolically. I attempted to fix this by being smarter when folding svalues and regions, but this fix seems too fiddly to attempt in stage 4. Instead, this less ambitious patch fixes a false positive from -Wanalyzer-use-of-uninitialized-value by making the analyzer's escape analysis smarter, so that it treats *PTR as escaping when (PTR + OFFSET) is passed to an external function, and thus it treats *PTR as possibly-initialized (the "passing &PTR[IDX]" case was already working). gcc/analyzer/ChangeLog: PR analyzer/105264 * region-model-reachability.cc (reachable_regions::handle_parm): Use maybe_get_deref_base_region rather than just region_svalue, to handle pointer arithmetic also. * svalue.cc (svalue::maybe_get_deref_base_region): New. * svalue.h (svalue::maybe_get_deref_base_region): New decl. gcc/testsuite/ChangeLog: PR analyzer/105264 * gcc.dg/analyzer/torture/symbolic-10.c: New test. Signed-off-by: David Malcolm Diff: --- gcc/analyzer/region-model-reachability.cc | 8 ++--- gcc/analyzer/svalue.cc | 42 ++++++++++++++++++++++ gcc/analyzer/svalue.h | 2 ++ .../gcc.dg/analyzer/torture/symbolic-10.c | 40 +++++++++++++++++++++ 4 files changed, 86 insertions(+), 6 deletions(-) diff --git a/gcc/analyzer/region-model-reachability.cc b/gcc/analyzer/region-model-reachability.cc index b876b8f0363..12d09c3e500 100644 --- a/gcc/analyzer/region-model-reachability.cc +++ b/gcc/analyzer/region-model-reachability.cc @@ -252,12 +252,8 @@ reachable_regions::handle_parm (const svalue *sval, tree param_type) m_mutable_svals.add (sval); else m_reachable_svals.add (sval); - if (const region_svalue *parm_ptr - = sval->dyn_cast_region_svalue ()) - { - const region *pointee_reg = parm_ptr->get_pointee (); - add (pointee_reg, is_mutable); - } + if (const region *base_reg = sval->maybe_get_deref_base_region ()) + add (base_reg, is_mutable); /* Treat all svalues within a compound_svalue as reachable. */ if (const compound_svalue *compound_sval = sval->dyn_cast_compound_svalue ()) diff --git a/gcc/analyzer/svalue.cc b/gcc/analyzer/svalue.cc index 536bc288dbf..a1403f0fbef 100644 --- a/gcc/analyzer/svalue.cc +++ b/gcc/analyzer/svalue.cc @@ -651,6 +651,48 @@ svalue::all_zeroes_p () const return false; } +/* If this svalue is a pointer, attempt to determine the base region it points + to. Return NULL on any problems. */ + +const region * +svalue::maybe_get_deref_base_region () const +{ + const svalue *iter = this; + while (1) + { + switch (iter->get_kind ()) + { + default: + return NULL; + + case SK_REGION: + { + const region_svalue *region_sval + = as_a (iter); + return region_sval->get_pointee ()->get_base_region (); + } + + case SK_BINOP: + { + const binop_svalue *binop_sval + = as_a (iter); + switch (binop_sval->get_op ()) + { + case POINTER_PLUS_EXPR: + /* If we have a symbolic value expressing pointer arithmetic, + use the LHS. */ + iter = binop_sval->get_arg0 (); + continue; + + default: + return NULL; + } + return NULL; + } + } + } +} + /* class region_svalue : public svalue. */ /* Implementation of svalue::dump_to_pp vfunc for region_svalue. */ diff --git a/gcc/analyzer/svalue.h b/gcc/analyzer/svalue.h index 4bbe8588b8d..29ea2ee6408 100644 --- a/gcc/analyzer/svalue.h +++ b/gcc/analyzer/svalue.h @@ -175,6 +175,8 @@ public: per-type and thus it's meaningless for them to "have state". */ virtual bool can_have_associated_state_p () const { return true; } + const region *maybe_get_deref_base_region () const; + protected: svalue (complexity c, tree type) : m_complexity (c), m_type (type) diff --git a/gcc/testsuite/gcc.dg/analyzer/torture/symbolic-10.c b/gcc/testsuite/gcc.dg/analyzer/torture/symbolic-10.c new file mode 100644 index 00000000000..b2f3a8a1d86 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/torture/symbolic-10.c @@ -0,0 +1,40 @@ +/* Verify that -fanalyzer considers that mmfs escapes when passing either: + *(mmfs + i) + and + (&mmfs[i]) + to an external function (for symbolic i). */ + +typedef struct s_mmfile { + char *ptr; + long size; +} mmfile_t; + +void init_mmfile(mmfile_t *ptr); + +long test__init_via_ptr_arith__read_via_array_idx(int i) +{ + mmfile_t mmfs[3]; + init_mmfile(mmfs + i); + return mmfs[i].size; /* { dg-bogus "uninit" } */ +} + +long test__init_via_array_idx__read_via_ptr_arith(int i) +{ + mmfile_t mmfs[3]; + init_mmfile(&mmfs[i]); + return (mmfs + i)->size; /* { dg-bogus "uninit" } */ +} + +long test__ptr_arith_for_both(int i) +{ + mmfile_t mmfs[3]; + init_mmfile(mmfs + i); + return (mmfs + i)->size; /* { dg-bogus "uninit" } */ +} + +long test__array_idx_for_both(int i) +{ + mmfile_t mmfs[3]; + init_mmfile(&mmfs[i]); + return mmfs[i].size; /* { dg-bogus "uninit" } */ +}