public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Michael Meissner <meissner@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/meissner/heads/work087)] Generate vadduqm and vsubuqm for TImode add/subtract Date: Thu, 28 Apr 2022 21:12:20 +0000 (GMT) [thread overview] Message-ID: <20220428211220.6216F3857823@sourceware.org> (raw) https://gcc.gnu.org/g:4b89839e555fb04bbca94ce5490d79cb4b90b59f commit 4b89839e555fb04bbca94ce5490d79cb4b90b59f Author: Michael Meissner <meissner@linux.ibm.com> Date: Thu Apr 28 17:11:58 2022 -0400 Generate vadduqm and vsubuqm for TImode add/subtract If the TImode variable is in an Altivec register instead of a GPR register, then generate vadduqm and vsubuqm instead of having to move the value to the GPR registers and doing the add and subtract with carry instructions. To do this, we have to delay the splitting of the addition and subtraction until after register allocation. 2022-04-28 Michael Meissner <meissner@linux.ibm.com> gcc/ * config/rs6000/rs6000.md (addti3): Generate vadduqm if we are using the Altivec registers. (subti3): Generate vsubuqm if we using the Altivec registers. (negti3): New insn. gcc/testsuite/ * gcc.target/powerpc/vadduqm-vsubuqm.c: New test. Diff: --- gcc/config/rs6000/rs6000.md | 82 ++++++++++++++++------ gcc/testsuite/gcc.target/powerpc/vadduqm-vsubuqm.c | 22 ++++++ 2 files changed, 83 insertions(+), 21 deletions(-) diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md index a78f419f5f3..b116195d491 100644 --- a/gcc/config/rs6000/rs6000.md +++ b/gcc/config/rs6000/rs6000.md @@ -7159,15 +7159,22 @@ ;; ;; Addti3/subti3 are define_insn_and_splits instead of define_expand, to allow ;; for combine to make things like multiply and add with extend operations. +;; +;; Also add support in case the 128-bit integer happens to be an Altivec +;; register. (define_insn_and_split "addti3" - [(set (match_operand:TI 0 "gpc_reg_operand" "=&r,r,r") - (plus:TI (match_operand:TI 1 "gpc_reg_operand" "r, 0,r") - (match_operand:TI 2 "reg_or_short_operand" "rI,r,0"))) + [(set (match_operand:TI 0 "gpc_reg_operand" "=&r, r,r,v") + (plus:TI (match_operand:TI 1 "gpc_reg_operand" "r, 0,r,v") + (match_operand:TI 2 "reg_or_short_operand" "rI,r,0,v"))) (clobber (reg:DI CA_REGNO))] "TARGET_64BIT" - "#" - "&& 1" + "@ + # + # + # + vadduqm %0,%1,%2" + "&& reload_completed && int_reg_operand (operands[0], TImode)" [(pc)] { rtx lo0 = gen_lowpart (DImode, operands[0]); @@ -7177,27 +7184,27 @@ rtx hi1 = gen_highpart (DImode, operands[1]); rtx hi2 = gen_highpart_mode (DImode, TImode, operands[2]); - if (!reg_or_short_operand (lo2, DImode)) - lo2 = force_reg (DImode, lo2); - if (!adde_operand (hi2, DImode)) - hi2 = force_reg (DImode, hi2); - emit_insn (gen_adddi3_carry (lo0, lo1, lo2)); emit_insn (gen_adddi3_carry_in (hi0, hi1, hi2)); DONE; } - [(set_attr "length" "8") + [(set_attr "length" "8,8,8,*") + (set_attr "isa" "*,*,*,p8v") (set_attr "type" "add") (set_attr "size" "128")]) (define_insn_and_split "subti3" - [(set (match_operand:TI 0 "gpc_reg_operand" "=&r,r,r") - (minus:TI (match_operand:TI 1 "reg_or_short_operand" "rI,0,r") - (match_operand:TI 2 "gpc_reg_operand" "r, r,0"))) + [(set (match_operand:TI 0 "gpc_reg_operand" "=&r, r,r,v") + (minus:TI (match_operand:TI 1 "reg_or_short_operand" "rI,0,r,v") + (match_operand:TI 2 "gpc_reg_operand" "r, r,0,v"))) (clobber (reg:DI CA_REGNO))] "TARGET_64BIT" - "#" - "&& 1" + "@ + # + # + # + vsubuqm %0,%1,%2" + "&& reload_completed && int_reg_operand (operands[0], TImode)" [(pc)] { rtx lo0 = gen_lowpart (DImode, operands[0]); @@ -7207,16 +7214,49 @@ rtx hi1 = gen_highpart_mode (DImode, TImode, operands[1]); rtx hi2 = gen_highpart (DImode, operands[2]); - if (!reg_or_short_operand (lo1, DImode)) - lo1 = force_reg (DImode, lo1); - if (!adde_operand (hi1, DImode)) - hi1 = force_reg (DImode, hi1); - emit_insn (gen_subfdi3_carry (lo0, lo2, lo1)); emit_insn (gen_subfdi3_carry_in (hi0, hi2, hi1)); DONE; +} + [(set_attr "length" "8,8,8,*") + (set_attr "isa" "*,*,*,p8v") + (set_attr "type" "add") + (set_attr "size" "128")]) + +;; 128-bit integer negation, normally use GPRs. If we are using Altivec +;; registers, create a 0 and do a vsubuqm. +(define_insn_and_split "negti3" + [(set (match_operand:TI 0 "gpc_reg_operand" "=&r,&v") + (neg:TI (match_operand:TI 1 "gpc_reg_operand" "r,v"))) + (clobber (reg:DI CA_REGNO))] + "TARGET_64BIT" + "#" + "&& reload_completed" + [(pc)] +{ + rtx dest = operands[0]; + rtx src = operands[1]; + + if (altivec_register_operand (dest, TImode)) + { + emit_move_insn (dest, const0_rtx); + emit_insn (gen_subti3 (dest, dest, src)); + DONE; + } + else + { + rtx dest_lo = gen_lowpart (DImode, dest); + rtx dest_hi = gen_highpart (DImode, dest); + rtx src_lo = gen_lowpart (DImode, src); + rtx src_hi = gen_highpart (DImode, src); + + emit_insn (gen_subfdi3_carry (dest_lo, src_lo, const0_rtx)); + emit_insn (gen_subfdi3_carry_in (dest_hi, src_hi, const0_rtx)); + DONE; + } } [(set_attr "length" "8") + (set_attr "isa" "*,p8v") (set_attr "type" "add") (set_attr "size" "128")]) \f diff --git a/gcc/testsuite/gcc.target/powerpc/vadduqm-vsubuqm.c b/gcc/testsuite/gcc.target/powerpc/vadduqm-vsubuqm.c new file mode 100644 index 00000000000..5cb2fe37e9c --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/vadduqm-vsubuqm.c @@ -0,0 +1,22 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target int128 } */ +/* { dg-options "-O2 -mdejagnu-cpu=power10" } */ +/* { dg-require-effective-target power10_ok } */ + +/* Test that we generate vadduqm and vsubuqm for 128-bit integer add and + subtracts if the value is in an Altivec register. We use 128-bit divide to + force the register selection to be in an altivec register. */ + +void +test (__int128_t *p, + __int128_t *q, + __int128_t *r, + __int128_t *s, + __int128_t *t) +{ + *p = (*q + *r) / (*s - *t); /* vadduqm, vsubuqm, vdivsq. */ +} + +/* { dg-final { scan-assembler {\mvadduqm\M} } } */ +/* { dg-final { scan-assembler {\mvdivsq\M} } } */ +/* { dg-final { scan-assembler {\mvsubuqm\M} } } */
reply other threads:[~2022-04-28 21:12 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220428211220.6216F3857823@sourceware.org \ --to=meissner@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).