From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id C939C385801E; Mon, 2 May 2022 11:17:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C939C385801E MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-71] tree-optimization/104240 - SLP discovery with swapped comparisons X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 86d821ddf5615e693ead667b2580898f46de8eb9 X-Git-Newrev: 41e3db05d697405256b6002d8432955a93d249f1 Message-Id: <20220502111706.C939C385801E@sourceware.org> Date: Mon, 2 May 2022 11:17:06 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 11:17:06 -0000 https://gcc.gnu.org/g:41e3db05d697405256b6002d8432955a93d249f1 commit r13-71-g41e3db05d697405256b6002d8432955a93d249f1 Author: Richard Biener Date: Mon May 2 12:01:51 2022 +0200 tree-optimization/104240 - SLP discovery with swapped comparisons The following extends SLP discovery to handle swapped operands in comparisons. 2022-05-02 Richard Biener PR tree-optimization/104240 * tree-vect-slp.cc (op1_op0_map): New. (vect_get_operand_map): Handle compares. (vect_build_slp_tree_1): Support swapped operands for tcc_comparison. * gcc.dg/vect/bb-slp-pr104240.c: New testcase. Diff: --- gcc/testsuite/gcc.dg/vect/bb-slp-pr104240.c | 14 ++++++++++++++ gcc/tree-vect-slp.cc | 19 ++++++++++++++++++- 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-pr104240.c b/gcc/testsuite/gcc.dg/vect/bb-slp-pr104240.c new file mode 100644 index 00000000000..78905a468e0 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/bb-slp-pr104240.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target vect_float } */ +/* { dg-require-effective-target vect_int } */ +/* { dg-require-effective-target vect_cond_mixed } */ + +void foo (int *c, float *x, float *y) +{ + c[0] = x[0] < y[0]; + c[1] = y[1] > x[1]; + c[2] = x[2] < y[2]; + c[3] = x[3] < y[3]; +} + +/* { dg-final { scan-tree-dump "optimized: basic block" "slp2" } } */ diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 0d400c00df1..2685bc10347 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -462,6 +462,7 @@ static const int cond_expr_maps[3][5] = { static const int arg1_map[] = { 1, 1 }; static const int arg2_map[] = { 1, 2 }; static const int arg1_arg4_map[] = { 2, 1, 4 }; +static const int op1_op0_map[] = { 2, 1, 0 }; /* For most SLP statements, there is a one-to-one mapping between gimple arguments and child nodes. If that is not true for STMT, @@ -482,6 +483,9 @@ vect_get_operand_map (const gimple *stmt, unsigned char swap = 0) if (gimple_assign_rhs_code (assign) == COND_EXPR && COMPARISON_CLASS_P (gimple_assign_rhs1 (assign))) return cond_expr_maps[swap]; + if (TREE_CODE_CLASS (gimple_assign_rhs_code (assign)) == tcc_comparison + && swap) + return op1_op0_map; } gcc_assert (!swap); if (auto call = dyn_cast (stmt)) @@ -1116,6 +1120,12 @@ vect_build_slp_tree_1 (vec_info *vinfo, unsigned char *swap, && (alt_stmt_code == PLUS_EXPR || alt_stmt_code == MINUS_EXPR) && rhs_code == alt_stmt_code) + && !(first_stmt_code.is_tree_code () + && rhs_code.is_tree_code () + && (TREE_CODE_CLASS (tree_code (first_stmt_code)) + == tcc_comparison) + && (swap_tree_comparison (tree_code (first_stmt_code)) + == tree_code (rhs_code))) && !(STMT_VINFO_GROUPED_ACCESS (stmt_info) && (first_stmt_code == ARRAY_REF || first_stmt_code == BIT_FIELD_REF @@ -1313,6 +1323,12 @@ vect_build_slp_tree_1 (vec_info *vinfo, unsigned char *swap, continue; } } + + if (rhs_code.is_tree_code () + && TREE_CODE_CLASS ((tree_code)rhs_code) == tcc_comparison + && (swap_tree_comparison ((tree_code)first_stmt_code) + == (tree_code)rhs_code)) + swap[i] = 1; } matches[i] = true; @@ -1326,7 +1342,8 @@ vect_build_slp_tree_1 (vec_info *vinfo, unsigned char *swap, with the permute we are going to use. */ if (alt_stmt_code != ERROR_MARK && (!alt_stmt_code.is_tree_code () - || TREE_CODE_CLASS (tree_code (alt_stmt_code)) != tcc_reference)) + || (TREE_CODE_CLASS (tree_code (alt_stmt_code)) != tcc_reference + && TREE_CODE_CLASS (tree_code (alt_stmt_code)) != tcc_comparison))) { *two_operators = true; }