From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 1334D38485AA; Fri, 6 May 2022 10:30:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1334D38485AA MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-8348] middle-end/105376 - invalid REAL_CST for DFP constant X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/releases/gcc-12 X-Git-Oldrev: e8cd7d0066e0ba2a082b0e7de35e883837546583 X-Git-Newrev: 39c56695c70a2052fc6bdcfca606dfff9c2fa975 Message-Id: <20220506103001.1334D38485AA@sourceware.org> Date: Fri, 6 May 2022 10:30:01 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2022 10:30:01 -0000 https://gcc.gnu.org/g:39c56695c70a2052fc6bdcfca606dfff9c2fa975 commit r12-8348-g39c56695c70a2052fc6bdcfca606dfff9c2fa975 Author: Richard Biener Date: Wed Apr 27 08:28:31 2022 +0200 middle-end/105376 - invalid REAL_CST for DFP constant We are eventually ICEing in decimal_to_decnumber on non-decimal REAL_VALUE_TYPE that creep in from uses of build_real (..., dconst*) for DFP types. The following extends the decimal_to_decnumber special-casing of dconst* to build_real, avoiding the bogus REAL_CSTs from creeping into the IL and modified to ones not handled by the decimal_to_decnumber special casing. It also makes sure to ICE for not handled dconst* values at the point we build the REAL_CST. 2022-04-27 Richard Biener PR middle-end/105376 * tree.cc (build_real): Special case dconst* arguments for decimal floating point types. * gcc.dg/pr105376.c: New testcase. (cherry picked from commit e27eef7478f30ea79048dbde3317e89679d75a6e) Diff: --- gcc/testsuite/gcc.dg/pr105376.c | 9 +++++++++ gcc/tree.cc | 21 +++++++++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/gcc/testsuite/gcc.dg/pr105376.c b/gcc/testsuite/gcc.dg/pr105376.c new file mode 100644 index 00000000000..f19ecf4aab2 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr105376.c @@ -0,0 +1,9 @@ +/* { dg-do compile { target dfp } } */ +/* { dg-options "-O -g" } */ + +void +foo (_Decimal64 d, _Decimal64 e) +{ + d -= -d; + d *= -e; +} diff --git a/gcc/tree.cc b/gcc/tree.cc index 3c39be4f501..4cf3785270b 100644 --- a/gcc/tree.cc +++ b/gcc/tree.cc @@ -70,6 +70,7 @@ along with GCC; see the file COPYING3. If not see #include "escaped_string.h" #include "gimple-range.h" #include "gomp-constants.h" +#include "dfp.h" /* Tree code classes. */ @@ -2383,6 +2384,26 @@ build_real (tree type, REAL_VALUE_TYPE d) REAL_VALUE_TYPE *dp; int overflow = 0; + /* dconst{1,2,m1,half} are used in various places in + the middle-end and optimizers, allow them here + even for decimal floating point types as an exception + by converting them to decimal. */ + if (DECIMAL_FLOAT_MODE_P (TYPE_MODE (type)) + && d.cl == rvc_normal + && !d.decimal) + { + if (memcmp (&d, &dconst1, sizeof (d)) == 0) + decimal_real_from_string (&d, "1"); + else if (memcmp (&d, &dconst2, sizeof (d)) == 0) + decimal_real_from_string (&d, "2"); + else if (memcmp (&d, &dconstm1, sizeof (d)) == 0) + decimal_real_from_string (&d, "-1"); + else if (memcmp (&d, &dconsthalf, sizeof (d)) == 0) + decimal_real_from_string (&d, "0.5"); + else + gcc_unreachable (); + } + /* ??? Used to check for overflow here via CHECK_FLOAT_TYPE. Consider doing it via real_convert now. */