From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 7165B3838008; Tue, 10 May 2022 08:24:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7165B3838008 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r10-10691] s390: Fix up *cmp_and_trap_unsigned_int constraints [PR104775] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/releases/gcc-10 X-Git-Oldrev: 3749dcd31f55ac72a162ecf83a40fa3278d3b086 X-Git-Newrev: 2183785c198ef17138985509cedf5051b3d58452 Message-Id: <20220510082454.7165B3838008@sourceware.org> Date: Tue, 10 May 2022 08:24:54 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2022 08:24:54 -0000 https://gcc.gnu.org/g:2183785c198ef17138985509cedf5051b3d58452 commit r10-10691-g2183785c198ef17138985509cedf5051b3d58452 Author: Jakub Jelinek Date: Mon Mar 7 11:14:04 2022 +0100 s390: Fix up *cmp_and_trap_unsigned_int constraints [PR104775] The following testcase fails to assemble due to clgte %r6,0(%r1,%r10) insn not being accepted by assembler. My rough understanding is that in the RSY-b insn format the spot in other formats used for index registers is used instead for M3 what kind of comparison it is, so this patch follows what other similar instructions use for constraint (i.e. one without index register). 2022-03-07 Jakub Jelinek PR target/104775 * config/s390/s390.md (*cmp_and_trap_unsigned_int): Use S constraint instead of T in the last alternative. * gcc.target/s390/pr104775.c: New test. (cherry picked from commit 2472dcaa8cb9e02e902f83d419c3ee7e0f3d9041) Diff: --- gcc/config/s390/s390.md | 2 +- gcc/testsuite/gcc.target/s390/pr104775.c | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/gcc/config/s390/s390.md b/gcc/config/s390/s390.md index 4039107a7be..2fc4924f59f 100644 --- a/gcc/config/s390/s390.md +++ b/gcc/config/s390/s390.md @@ -9474,7 +9474,7 @@ (define_insn "*cmp_and_trap_unsigned_int" [(trap_if (match_operator 0 "s390_unsigned_integer_comparison" [(match_operand:GPR 1 "register_operand" "d,d,d") - (match_operand:GPR 2 "general_operand" "d,D,T")]) + (match_operand:GPR 2 "general_operand" "d,D,S")]) (const_int 0))] "TARGET_Z10" "@ diff --git a/gcc/testsuite/gcc.target/s390/pr104775.c b/gcc/testsuite/gcc.target/s390/pr104775.c new file mode 100644 index 00000000000..fd4258bb36f --- /dev/null +++ b/gcc/testsuite/gcc.target/s390/pr104775.c @@ -0,0 +1,14 @@ +/* PR target/104775 */ +/* { dg-do assemble { target s390_zEC12_hw } } */ +/* { dg-options "-O2 -march=zEC12" } */ + +long a[64]; +void bar (void); + +void +foo (int x, int y) +{ + if (x != a[y]) + bar (); + __builtin_trap (); +}