public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r10-10699] c++: Fix up __builtin_convertvector parsing
Date: Tue, 10 May 2022 08:25:36 +0000 (GMT)	[thread overview]
Message-ID: <20220510082536.233063838008@sourceware.org> (raw)

https://gcc.gnu.org/g:91cc882245d7d93876d34f4d4c2e425acf48c8bb

commit r10-10699-g91cc882245d7d93876d34f4d4c2e425acf48c8bb
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Mar 26 08:11:58 2022 +0100

    c++: Fix up __builtin_convertvector parsing
    
    Jonathan reported on IRC that we don't parse
    __builtin_bit_cast (type, val).field
    etc.
    The problem is that for these 2 builtins we return from
    cp_parser_postfix_expression instead of setting postfix_expression
    to the cp_build_* value and falling through into the postfix regression
    suffix handling loop.
    
    2022-03-26  Jakub Jelinek  <jakub@redhat.com>
    
            * parser.c (cp_parser_postfix_expression)
            <case RID_BILTIN_CONVERTVECTOR>: Don't
            return cp_build_vec_convert result right away, instead
            set postfix_expression to it and break.
    
            * c-c++-common/builtin-convertvector-3.c: New test.
    
    (cherry picked from commit 1806829e08f14e4cacacec43d7845cc2dad2ddc8)

Diff:
---
 gcc/cp/parser.c                                      |  6 ++++--
 gcc/testsuite/c-c++-common/builtin-convertvector-3.c | 11 +++++++++++
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c
index f48c856fa94..61f2af34688 100644
--- a/gcc/cp/parser.c
+++ b/gcc/cp/parser.c
@@ -7162,8 +7162,10 @@ cp_parser_postfix_expression (cp_parser *parser, bool address_p, bool cast_p,
 	}
 	/* Look for the closing `)'.  */
 	parens.require_close (parser);
-	return cp_build_vec_convert (expression, type_location, type,
-				     tf_warning_or_error);
+	postfix_expression
+	  = cp_build_vec_convert (expression, type_location, type,
+				  tf_warning_or_error);
+	break;
       }
 
     default:
diff --git a/gcc/testsuite/c-c++-common/builtin-convertvector-3.c b/gcc/testsuite/c-c++-common/builtin-convertvector-3.c
new file mode 100644
index 00000000000..882cd551ef8
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/builtin-convertvector-3.c
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+
+typedef int v4si __attribute__((vector_size (4 * sizeof (int))));
+typedef double v4df __attribute__((vector_size (4 * sizeof (double))));
+double
+foo (void)
+{
+  v4si a = { 1, 2, 3, 4 };
+  return __builtin_convertvector (a, v4df)[1];
+}


                 reply	other threads:[~2022-05-10  8:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220510082536.233063838008@sourceware.org \
    --to=jakub@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).