From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 6DF1F3839802; Wed, 11 May 2022 06:25:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DF1F3839802 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r9-10140] i386: Don't emit pushf; pop for __builtin_ia32_readeflags_u* with unused lhs [PR104971] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/releases/gcc-9 X-Git-Oldrev: 0e02b8468be6b655c43c6d64fef7724444678681 X-Git-Newrev: c1a8261b7054da31420e5c715e682c1b42e473b5 Message-Id: <20220511062549.6DF1F3839802@sourceware.org> Date: Wed, 11 May 2022 06:25:49 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 06:25:49 -0000 https://gcc.gnu.org/g:c1a8261b7054da31420e5c715e682c1b42e473b5 commit r9-10140-gc1a8261b7054da31420e5c715e682c1b42e473b5 Author: Jakub Jelinek Date: Sat Mar 19 13:53:12 2022 +0100 i386: Don't emit pushf;pop for __builtin_ia32_readeflags_u* with unused lhs [PR104971] __builtin_ia32_readeflags_u* aren't marked const or pure I think intentionally, so that they aren't CSEd from different regions of a function etc. because we don't and can't easily track all dependencies between it and surrounding code (if somebody looks at the condition flags, it is dependent on the vast majority of instructions). But the builtin itself doesn't have any side-effects, so if we ignore the result of the builtin, there is no point to emit anything. There is a LRA bug that miscompiles the testcase which this patch makes latent, which is certainly worth fixing too, but IMHO this change (and maybe ix86_gimple_fold_builtin too which would fold it even earlier when it looses lhs) is worth it as well. 2022-03-19 Jakub Jelinek PR middle-end/104971 * config/i386/i386.c (ix86_expand_builtin) : If ignore, don't push/pop anything and just return const0_rtx. * gcc.target/i386/pr104971.c: New test. (cherry picked from commit b60bc913cca7439d29a7ec9e9a7f448d8841b43c) Diff: --- gcc/config/i386/i386.c | 3 +++ gcc/testsuite/gcc.target/i386/pr104971.c | 18 ++++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 3f9b092bf58..cb631f7c829 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -37595,6 +37595,9 @@ rdseed_step: return target; case IX86_BUILTIN_READ_FLAGS: + if (ignore) + return const0_rtx; + emit_insn (gen_push (gen_rtx_REG (word_mode, FLAGS_REG))); if (optimize diff --git a/gcc/testsuite/gcc.target/i386/pr104971.c b/gcc/testsuite/gcc.target/i386/pr104971.c new file mode 100644 index 00000000000..80ac6b613f1 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr104971.c @@ -0,0 +1,18 @@ +/* PR middle-end/104971 */ +/* { dg-do run } */ +/* { dg-options "-O2" } */ + +#include + +__attribute__((noipa)) void +foo (void) +{ + __readeflags (); +} + +int +main () +{ + foo (); + return 0; +}