public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Pierre-Marie de Rodat <pmderodat@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-384] [Ada] Remove redundant guard in checks for volatile actuals
Date: Fri, 13 May 2022 08:07:20 +0000 (GMT)	[thread overview]
Message-ID: <20220513080720.01DCE385043A@sourceware.org> (raw)

https://gcc.gnu.org/g:7427e673d818be052fd07468c9dfdad3dbfe13b3

commit r13-384-g7427e673d818be052fd07468c9dfdad3dbfe13b3
Author: Piotr Trojanek <trojanek@adacore.com>
Date:   Wed Feb 16 10:15:12 2022 +0100

    [Ada] Remove redundant guard in checks for volatile actuals
    
    When flagging names of volatile objects occurring in actual parameters
    we guard against identifiers without entity. This is redundant, because
    earlier in the resolution of actual parameters we already guard against
    actuals with Any_Type.
    
    Code cleanup related to handling of volatile components; behaviour is
    unaffected.
    
    gcc/ada/
    
            * sem_res.adb (Flag_Effectively_Volatile_Objects): Remove
            redundant guard.

Diff:
---
 gcc/ada/sem_res.adb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gcc/ada/sem_res.adb b/gcc/ada/sem_res.adb
index f038a33eb55..4ae0835498b 100644
--- a/gcc/ada/sem_res.adb
+++ b/gcc/ada/sem_res.adb
@@ -3868,8 +3868,7 @@ package body Sem_Res is
                when N_Identifier | N_Expanded_Name =>
                   Id := Entity (N);
 
-                  if Present (Id)
-                    and then Is_Object (Id)
+                  if Is_Object (Id)
                     and then Is_Effectively_Volatile_For_Reading (Id)
                     and then
                       not Is_OK_Volatile_Context (Context       => Parent (N),


                 reply	other threads:[~2022-05-13  8:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220513080720.01DCE385043A@sourceware.org \
    --to=pmderodat@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).