public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Pierre-Marie de Rodat <pmderodat@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-385] [Ada] Accept effectively volatile components in actuals
Date: Fri, 13 May 2022 08:07:25 +0000 (GMT)	[thread overview]
Message-ID: <20220513080725.1CFB7385736C@sourceware.org> (raw)

https://gcc.gnu.org/g:74ce1d5a6cbcf81e21b4c0eeee372df46c275df0

commit r13-385-g74ce1d5a6cbcf81e21b4c0eeee372df46c275df0
Author: Piotr Trojanek <trojanek@adacore.com>
Date:   Wed Feb 16 12:13:57 2022 +0100

    [Ada] Accept effectively volatile components in actuals
    
    In SPARK we forbid names that are effectively volatile for reading if
    they occur in actual subprogram parameters. We wrongly rejected
    references to components, which are not names in Ada.
    
    gcc/ada/
    
            * sem_res.adb (Flag_Effectively_Volatile_Objects): Ignore
            component and discriminant identifiers.

Diff:
---
 gcc/ada/sem_res.adb | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gcc/ada/sem_res.adb b/gcc/ada/sem_res.adb
index 4ae0835498b..4306e49ed76 100644
--- a/gcc/ada/sem_res.adb
+++ b/gcc/ada/sem_res.adb
@@ -3868,7 +3868,13 @@ package body Sem_Res is
                when N_Identifier | N_Expanded_Name =>
                   Id := Entity (N);
 
+                  --  Identifiers of components and discriminants are not names
+                  --  in the sense of Ada RM 4.1. They can only occur as a
+                  --  selector_name in selected_component or as a choice in
+                  --  component_association.
+
                   if Is_Object (Id)
+                    and then Ekind (Id) not in E_Component | E_Discriminant
                     and then Is_Effectively_Volatile_For_Reading (Id)
                     and then
                       not Is_OK_Volatile_Context (Context       => Parent (N),


                 reply	other threads:[~2022-05-13  8:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220513080725.1CFB7385736C@sourceware.org \
    --to=pmderodat@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).