From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1851) id C60AD3857C6F; Mon, 16 May 2022 07:50:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C60AD3857C6F Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Martin Liska To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/marxin/heads/fix-ubsan-opts-global.cc)] Fix ubsan error in opts-global.cc X-Act-Checkin: gcc X-Git-Author: Martin Liska X-Git-Refname: refs/users/marxin/heads/fix-ubsan-opts-global.cc X-Git-Oldrev: 69c4b5c519f0df37e4903992644cc29682721bc1 X-Git-Newrev: 7b43fcd2310b981b0c6a042b6fed45d12346b8c4 Message-Id: <20220516075001.C60AD3857C6F@sourceware.org> Date: Mon, 16 May 2022 07:50:01 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 07:50:01 -0000 https://gcc.gnu.org/g:7b43fcd2310b981b0c6a042b6fed45d12346b8c4 commit 7b43fcd2310b981b0c6a042b6fed45d12346b8c4 Author: Martin Liska Date: Mon May 16 09:48:27 2022 +0200 Fix ubsan error in opts-global.cc Fixes: opts-global.cc:75:15: runtime error: store to address 0x00000bc9be70 with insufficient space for an object of type 'char' which happens when mask == 0, len == 0 and we allocate zero elements. Eventually, result[0] is called which triggers the UBSAN. gcc/ChangeLog: * opts-global.cc (write_langs): Allocate at least one byte. Diff: --- gcc/opts-global.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/opts-global.cc b/gcc/opts-global.cc index a18c76940f9..4f5f8cdcb98 100644 --- a/gcc/opts-global.cc +++ b/gcc/opts-global.cc @@ -61,7 +61,7 @@ write_langs (unsigned int mask) if (mask & (1U << n)) len += strlen (lang_name) + 1; - result = XNEWVEC (char, len); + result = XNEWVEC (char, MAX (1, len)); len = 0; for (n = 0; (lang_name = lang_names[n]) != 0; n++) if (mask & (1U << n))