From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2078) id 7ACCF3858C51; Tue, 17 May 2022 00:59:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7ACCF3858C51 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: hongtao Liu To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-517] Clamp vec_perm_expr index in simplify_bitfield_ref to avoid ICE. X-Act-Checkin: gcc X-Git-Author: liuhongt X-Git-Refname: refs/heads/master X-Git-Oldrev: 702bd11fa7ddfce0d24581251e979e8a6d7c0d4d X-Git-Newrev: 1fba0608d12a209a5d76d65bcb1dec1c07bc33e9 Message-Id: <20220517005958.7ACCF3858C51@sourceware.org> Date: Tue, 17 May 2022 00:59:58 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 00:59:58 -0000 https://gcc.gnu.org/g:1fba0608d12a209a5d76d65bcb1dec1c07bc33e9 commit r13-517-g1fba0608d12a209a5d76d65bcb1dec1c07bc33e9 Author: liuhongt Date: Mon May 16 09:06:04 2022 +0800 Clamp vec_perm_expr index in simplify_bitfield_ref to avoid ICE. gcc/ChangeLog: PR tree-optimization/105591 * tree-ssa-forwprop.cc (simplify_bitfield_ref): Clamp vec_perm_expr index. gcc/testsuite/ChangeLog: * gcc.dg/pr105591.c: New test. Diff: --- gcc/testsuite/gcc.dg/pr105591.c | 12 ++++++++++++ gcc/tree-ssa-forwprop.cc | 13 ++++++++----- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/gcc/testsuite/gcc.dg/pr105591.c b/gcc/testsuite/gcc.dg/pr105591.c new file mode 100644 index 00000000000..9554c42e2f4 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr105591.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-Wno-psabi -O" } */ +/* { dg-additional-options "-mavx" { target x86_64-*-* i?86-*-* } } */ +typedef unsigned long long __attribute__((__vector_size__ (16))) U; +typedef unsigned long long __attribute__((__vector_size__ (32))) V; + +V +foo (U u) +{ + U x = __builtin_shuffle (u, (U) { 0xBE2ED0AB630B33FE }); + return __builtin_shufflevector (u, x, 2, 1, 0, 3); +} diff --git a/gcc/tree-ssa-forwprop.cc b/gcc/tree-ssa-forwprop.cc index 48cab5844e0..7da3f80af10 100644 --- a/gcc/tree-ssa-forwprop.cc +++ b/gcc/tree-ssa-forwprop.cc @@ -2381,23 +2381,26 @@ simplify_bitfield_ref (gimple_stmt_iterator *gsi) /* One element. */ if (known_eq (size, elem_size)) - idx = TREE_INT_CST_LOW (VECTOR_CST_ELT (m, idx)); + idx = TREE_INT_CST_LOW (VECTOR_CST_ELT (m, idx)) % (2 * nelts); else { unsigned HOST_WIDE_INT nelts_op; if (!constant_multiple_p (size, elem_size, &nelts_op) || !pow2p_hwi (nelts_op)) return false; - unsigned start = TREE_INT_CST_LOW (vector_cst_elt (m, idx)); - unsigned end = TREE_INT_CST_LOW (vector_cst_elt (m, idx + nelts_op - 1)); + /* Clamp vec_perm_expr index. */ + unsigned start = TREE_INT_CST_LOW (vector_cst_elt (m, idx)) % (2 * nelts); + unsigned end = TREE_INT_CST_LOW (vector_cst_elt (m, idx + nelts_op - 1)) + % (2 * nelts); /* Be in the same vector. */ if ((start < nelts) != (end < nelts)) return false; for (unsigned HOST_WIDE_INT i = 1; i != nelts_op; i++) { /* Continuous area. */ - if (TREE_INT_CST_LOW (vector_cst_elt (m, idx + i)) - 1 - != TREE_INT_CST_LOW (vector_cst_elt (m, idx + i - 1))) + if (TREE_INT_CST_LOW (vector_cst_elt (m, idx + i)) % (2 * nelts) - 1 + != TREE_INT_CST_LOW (vector_cst_elt (m, idx + i - 1)) + % (2 * nelts)) return false; } /* Alignment not worse than before. */