public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/aoliva/heads/testme)] [PR105665] ivopts: check defs of names in base for undefs Date: Thu, 26 May 2022 13:11:21 +0000 (GMT) [thread overview] Message-ID: <20220526131121.18E163856084@sourceware.org> (raw) https://gcc.gnu.org/g:38cb5568ce3b8bfae001df066f5c5e9d1a7fe649 commit 38cb5568ce3b8bfae001df066f5c5e9d1a7fe649 Author: Alexandre Oliva <oliva@adacore.com> Date: Thu May 26 09:15:53 2022 -0300 [PR105665] ivopts: check defs of names in base for undefs Diff: --- gcc/testsuite/gcc.dg/torture/pr105665.c | 2 +- gcc/tree-ssa-loop-ivopts.cc | 19 +++++++++++++++---- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/gcc/testsuite/gcc.dg/torture/pr105665.c b/gcc/testsuite/gcc.dg/torture/pr105665.c index 12f0b78a4b4..34cfc658434 100644 --- a/gcc/testsuite/gcc.dg/torture/pr105665.c +++ b/gcc/testsuite/gcc.dg/torture/pr105665.c @@ -6,7 +6,7 @@ int main() { for (; b < 2; b++) { int g; if (f) - b = 40; + g++, b = 40; a = d[b * b]; for (f = 0; f < 3; f++) { if (e) diff --git a/gcc/tree-ssa-loop-ivopts.cc b/gcc/tree-ssa-loop-ivopts.cc index 2e8cd486cc0..e68968efc5f 100644 --- a/gcc/tree-ssa-loop-ivopts.cc +++ b/gcc/tree-ssa-loop-ivopts.cc @@ -3074,10 +3074,18 @@ get_loop_invariant_expr (struct ivopts_data *data, tree inv_expr) /* Find the first undefined SSA name in *TP. */ static tree -find_ssa_undef (tree *tp, int *walk_subtrees, void *) +find_ssa_undef (tree *tp, int *walk_subtrees, void *pset_) { + auto pset = static_cast<hash_set<tree> *> (pset_); + if (TREE_CODE (*tp) == SSA_NAME) { + /* If we've already visited this SSA_NAME and got to it again, + we know we didn't find it to be undefined, otherwise we'd + have stopped the walk then. */ + if (pset && pset->add (*tp)) + return NULL; + if (ssa_undefined_value_p (*tp, false)) return *tp; @@ -3092,8 +3100,10 @@ find_ssa_undef (tree *tp, int *walk_subtrees, void *) { tree use = USE_FROM_PTR (use_p); - if (ssa_undefined_value_p (use, false)) - return use; + int wsub = 1; + tree result = find_ssa_undef (&use, &wsub, pset); + if (result) + return result; } } @@ -3132,7 +3142,8 @@ add_candidate_1 (struct ivopts_data *data, tree base, tree step, bool important, /* If BASE contains undefined SSA names make sure we only record the original IV. */ bool involves_undefs = false; - if (walk_tree (&base, find_ssa_undef, NULL, NULL)) + hash_set<tree> pset; + if (walk_tree (&base, find_ssa_undef, &pset, NULL)) { if (pos != IP_ORIGINAL) return NULL;
next reply other threads:[~2022-05-26 13:11 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-26 13:11 Alexandre Oliva [this message] -- strict thread matches above, loose matches on Subject: below -- 2022-06-02 11:58 Alexandre Oliva 2022-06-02 1:27 Alexandre Oliva 2022-05-28 4:45 Alexandre Oliva 2022-05-28 0:11 Alexandre Oliva 2022-05-28 0:09 Alexandre Oliva 2022-05-26 15:46 Alexandre Oliva 2022-05-26 15:46 Alexandre Oliva 2022-05-26 14:29 Alexandre Oliva 2022-05-26 12:49 Alexandre Oliva 2022-05-26 12:49 Alexandre Oliva
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220526131121.18E163856084@sourceware.org \ --to=aoliva@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).