From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1698) id 960AD3829BDD; Sun, 29 May 2022 19:10:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 960AD3829BDD MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Iain D Sandoe To: gcc-cvs@gcc.gnu.org Subject: [gcc r10-10790] collect2: Fix missing cleanups. X-Act-Checkin: gcc X-Git-Author: Iain Sandoe X-Git-Refname: refs/heads/releases/gcc-10 X-Git-Oldrev: 92f4797ac645c81b6299729113b4d20fbc836007 X-Git-Newrev: b1c3f26297f35570b91f32bea0b13ab257db45de Message-Id: <20220529191017.960AD3829BDD@sourceware.org> Date: Sun, 29 May 2022 19:10:17 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 May 2022 19:10:17 -0000 https://gcc.gnu.org/g:b1c3f26297f35570b91f32bea0b13ab257db45de commit r10-10790-gb1c3f26297f35570b91f32bea0b13ab257db45de Author: Iain Sandoe Date: Wed Oct 6 14:58:33 2021 +0100 collect2: Fix missing cleanups. The code that checks to see if objects have LTO content via simple-object was not releasing resources, fixed thus. Signed-off-by: Iain Sandoe gcc/ChangeLog: * collect2.c (is_lto_object_file): Release simple-object resources, close files. (cherry picked from commit 43ae43f654749d291d871ca6ef7c96ea16580fad) Diff: --- gcc/collect2.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gcc/collect2.c b/gcc/collect2.c index defd261027f..5ff59aeedcc 100644 --- a/gcc/collect2.c +++ b/gcc/collect2.c @@ -2301,10 +2301,15 @@ is_lto_object_file (const char *prog_name) LTO_SEGMENT_NAME, &errmsg, &err); if (!inobj) - return false; + { + close (infd); + return false; + } errmsg = simple_object_find_sections (inobj, has_lto_section, (void *) &found, &err); + simple_object_release_read (inobj); + close (infd); if (! errmsg && found) return true;